Fix Jackson auto-configuration classpath guard - #1408
Open
ikjeong wants to merge 1 commit into
Open
Conversation
Use JacksonModule instead of java.lang.Module so Feign Jackson auto-configuration is skipped when Jackson databind is absent. Fixes spring-cloudgh-1407 Signed-off-by: ikjeong <jipark7937@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-1407
This change replaces the accidentally resolved
java.lang.Modulewith Jackson 3'sJacksonModulein the Feign Jackson classpath condition. This prevents the Page and Sort Jackson modules from being configured when Jackson databind is absent.It adds tests covering three classpath scenarios: all required classes are present, Jackson databind is absent, and Spring Data is absent.