Add ResourcesItemReaderBuilder with support for a file pattern - #5488
Open
benelog wants to merge 1 commit into
Open
Add ResourcesItemReaderBuilder with support for a file pattern#5488benelog wants to merge 1 commit into
benelog wants to merge 1 commit into
Conversation
ResourcesItemReader was the only reader in the item.file package without a builder, and resolving a file pattern into resources was left to the user in Java configuration. This commit adds ResourcesItemReaderBuilder with resources(), filesPattern() and name() methods. The filesPattern() method resolves the pattern with PathMatchingResourcePatternResolver, consistent with the method of the same name proposed for MultiResourceItemReaderBuilder. Resolves spring-projects#5487 Signed-off-by: Sanghyuk Jung <sanghyuk.jung@navercorp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5487
The new
ResourcesItemReaderBuilderfollows the structure of the existing builders in the same package. SinceResourcesItemReaderhas nosaveStateorstrictproperties, the builder only exposesresources(Resource...),filesPattern(String)andname(String). Thenameis optional because the reader falls back to a class-name-based execution context key.The
filesPattern(String)method has the same name and semantics as the one proposed forMultiResourceItemReaderBuilderin #5071: the pattern is resolved byPathMatchingResourcePatternResolverwith a "file:" prefix at build time. The test resource files are namedresource1.txtandresource2.txtso that they do not clash with thetest1.txt/test2.txtfiles added by #5071 in the same directory, in case both PRs get merged.