GH-5486: Fix NPE in JpaCursorItemReader.doClose() when reader was nev… - #5489
Open
dhritimanchakra wants to merge 1 commit into
Open
GH-5486: Fix NPE in JpaCursorItemReader.doClose() when reader was nev…#5489dhritimanchakra wants to merge 1 commit into
dhritimanchakra wants to merge 1 commit into
Conversation
… reader was never opened entityManager is only assigned in doOpen() and is @nullable, but doClose() called entityManager.close() with no null check. Spring calls close() on every singleton ItemReader bean at context shutdown regardless of whether its step ran, causing an NPE wrapped as ItemStreamException for readers that were never opened. The check was accidentally dropped in 551e26d when @nullable was added without preserving the runtime guard. Fixes spring-projects#5486 Signed-off-by: Dhritiman Chakrabarty <dhritimancg@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…er opened
entityManageris only assigned indoOpen()and is@Nullable, butdoClose()calledentityManager.close()with no null check. Springcalls
close()on every singletonItemReaderbean at contextshutdown regardless of whether its step ran, causing an NPE wrapped
as
ItemStreamExceptionfor readers that were never opened.The check was accidentally dropped in 551e26d when
@Nullablewasadded without preserving the runtime guard.
Fixes #5486
Thank you for taking time to contribute this pull request!
You might have already read the [contributor guide][1], but as a reminder, please make sure to:
mainbranch and squash your commitsFor more details, please check the [contributor guide][1].
Thank you upfront!