GH-5481: Fix JSON functional test on Windows - #5491
Open
hutiefang76 wants to merge 1 commit into
Open
Conversation
Signed-off-by: 胡铁芳 <137664623+hutiefang76@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5481.
The JSON writer is configured to emit LF line endings, while Git may check out the expected JSON resource with CRLF on Windows. Comparing raw MD5 hashes therefore fails even when the JSON output is otherwise identical.
This change normalizes CRLF only in the checked-out expected file. The generated file remains an exact comparison so the test still verifies the writer's configured LF separator. The added tests cover both the Windows checkout case and the inverse case where generated output incorrectly uses CRLF.
Tests:
./mvnw -pl spring-batch-samples -Dit.test=JsonFunctionalTests verify./mvnw -pl spring-batch-samples verify(74 completed, 0 failures/errors, 11 skipped)