Exclude AspectJ builddef.lst from published JARs. - #4351
Closed
kalayciburak wants to merge 1 commit into
Closed
kalayciburak wants to merge 1 commit into
kalayciburak wants to merge 1 commit into
Conversation
aspectj-maven-plugin writes its compiler argument file into target/classes by default, so the published artifact ships a local-path build definition. Relocate that file out of the classes directory and exclude it from the JAR. Closes spring-projects#4350 Signed-off-by: Burak KALAYCI <kalayciburak1996@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
mp911de
reviewed
Sep 15, 2026
| <verbose>true</verbose> | ||
| <showWeaveInfo>true</showWeaveInfo> | ||
| <!-- Keep AJC's argument file out of target/classes so it is not packaged. --> | ||
| <argumentFileName>../builddef.lst</argumentFileName> |
mp911de
added
type: task
Member
|
Thank you for your contribution. That's merged, polished, and backported now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aspectj-maven-pluginwritesbuilddef.lstintotarget/classesby default, so the publishedspring-data-jpaJAR shipped a local-path AJC argument file.target/builddef.lstand excludebuilddef.lstfrom the JAR.Closes #4350
Test plan
Executed:
./mvnw -pl spring-data-jpa -am package -DskipTests(before):jar tflistedbuilddef.lst../mvnw -pl spring-data-jpa -am package -DskipTests(after):jar tfno longer listsbuilddef.lst;Automatic-Module-Name/Implementation-*manifest entries remain../mvnw -pl spring-data-jpa -Dtest=AuditingNamespaceUnitTests,JpaRuntimeHintsUnitTests test: 7 tests, 0 failures (Surefire default/unit/integration/eclipselink executions).