Conversation
The three-argument constructor asserted `key` twice. The second check used the message "QueryableEncryptionOptions must not be empty", but `queryableEncryptionOptions` is `@Nullable` and the two-argument constructor passes `null` for it, so it must not be validated. The assertion is therefore both redundant (re-checking `key`) and misleading, so remove it. Closes spring-projects#5241 Signed-off-by: kdomo <dongho5088@naver.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The three-argument
EncryptionOptionsconstructor assertskeytwice:The third assertion re-checks
keywhile its message namesqueryableEncryptionOptions. That parameter is@Nullableand the two-argument constructor passesnullfor it, so it must not be validated. The assertion is both redundant and misleading, so this removes it.Closes #5241