Repository navigation
Check for integer overflow when narrowing Query skip - #5244
Open
anjeongkyun wants to merge 1 commit into
Open
anjeongkyun wants to merge 1 commit into
anjeongkyun wants to merge 1 commit into
Conversation
Query.skip takes a long and Pageable.getOffset() is a long, but the driver and the wire protocol take an int. A skip above Integer.MAX_VALUE wrapped to a negative and was handed to the driver as such: PageRequest.of(500_000, 5_000) carries an offset of 2_500_000_000, which arrived as -1_794_967_296. The three narrowing sites now go through a shared check that reports the value instead. Signed-off-by: anjeongkyun <anwjdrbs123@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Query.skiptakes alongandPageable.getOffset()returns along, but the driver and the wire protocol take anint. Three places narrowed with a plain cast:The
> 0check passes for a large skip, and the cast then wraps it to a negative that goes straight to the driver.PageRequest.of(500_000, 5_000)carries an offset of 2,500,000,000, which arrives as -1,794,967,296, andSliceUtils.limitResultfeeds exactly that intoQuery.skip.Change
The three sites share a check that reports the offending value rather than wrapping it.
skipvalues inside the range behave as before.I put the helper on
QueryOperationssince two of the three callers already reach for it; say the word if you would rather have it somewhere else, or inline at each site.QueryOperationsUnitTests,MongoTemplateUnitTestsandReactiveMongoTemplateUnitTestspass (356 tests). The new test fails without the change.There is no ticket for this one, happy to add the
GH-reference to the tests if you open one.