Replace stray mysema Assert with springframework Assert - #1584
Merged
jzheaux merged 1 commit intoAug 27, 2026
Conversation
kalayciburak
force-pushed
the
fix/1546-mysema-assert-import
branch
from
August 1, 2026 08:58
a6de598 to
4ac2db5
Compare
jzheaux
force-pushed
the
fix/1546-mysema-assert-import
branch
from
August 27, 2026 00:30
4ac2db5 to
8fe7996
Compare
AbstractCompensatingTransactionManagerDelegate imported com.mysema.commons.lang.Assert, which is not on the spring-ldap-core runtime classpath unless optional Querydsl is present. That causes NoClassDefFoundError when committing/rolling back compensating transactions. Use org.springframework.util.Assert like the rest of the module. Closes spring-projectsgh-1546 Signed-off-by: Burak KALAYCI <kalayciburak1996@gmail.com>
jzheaux
changed the title
jzheaux
force-pushed
the
fix/1546-mysema-assert-import
branch
from
August 27, 2026 01:00
8fe7996 to
916d651
Compare
Collaborator
|
Thanks very much, @kalayciburak! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AbstractCompensatingTransactionManagerDelegateimportedcom.mysema.commons.lang.Assert, which is not on thespring-ldap-coreruntime classpath unless optional Querydsl is present. Calling commit/rollback then fails withNoClassDefFoundError: com/mysema/commons/lang/Assert.This switches the import to
org.springframework.util.Assert, consistent with the rest of the module.Fixes #1546
Test plan
:spring-ldap-core:compileJava:spring-ldap-core:testfocused compensating-transaction suites — 59 tests, 0 failures:spring-ldap-core:checkstyleMaincom.mysemareferences