Fix/octopus crash#3903
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a crash in the Octopus Intelligent Devices flow by handling GraphQL responses where dispatch arrays are present but null, preventing iteration over None. This is a small reliability patch in the Octopus integration code path, along with a version bump in the main PredBat entrypoint.
Changes:
- Bump PredBat version from
v8.39.0tov8.39.1. - Guard
flexPlannedDispatches/completedDispatchesparsing soNonebecomes an empty list before iterating.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/predbat/predbat.py | Version bump to v8.39.1. |
| apps/predbat/octopus.py | Prevent crash when Octopus GraphQL returns null for dispatch arrays by defaulting to []. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.