Implement thread-safe log file management#3904
Closed
daviessm wants to merge 1 commit into
Closed
Conversation
Added thread safety for log file renaming and handling.
Owner
|
Didn't quite work as the lock broke the execution pool PICKLE, I'll re-do it another way |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When debugging I was getting a lot of crashes because files couldn't be renamed due to multiple threads trying to rename files at the same time. Use a mutex to prevent this and also ignore errors caused by missing files - hacky, but better than crashing.