Skip to content

Draw the pen's wet stroke over containers, not under them #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcosqlbi merged 1 commit into from
Aug 27, 2026
+10 −7
Merged

Draw the pen's wet stroke over containers, not under them #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
scripts/build-installer.ps1 both read it from here, so releasing is a reviewed change
to this line rather than an edit in a pipeline variable group.
-->
<VersionPrefix>1.1.1</VersionPrefix>
<VersionPrefix>1.1.2</VersionPrefix>
<LangVersion>latest</LangVersion>
<Nullable>enable</Nullable>
<ImplicitUsings>enable</ImplicitUsings>
Expand Down
2 changes: 1 addition & 1 deletion TODO.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ The delivery chain works end to end: a merge to `main` builds, signs, and publis
pre-release to GitHub Releases, and one approval promotes that same build to a release.
<https://whiteboard.sqlbi.com> reads its download links from the release manifest
deployed beside it and needs no edit per release. The current product version is `VersionPrefix` in `Directory.Build.props`
(1.1.1). Identity version for the Store package is `VersionPrefix.0` (`1.1.1.0`).
(1.1.2). Identity version for the Store package is `VersionPrefix.0` (`1.1.2.0`).

Declaring that number is decision 20 in [docs/decisions.md](docs/decisions.md). What 1.0
was waiting on shipped during 0.9.x: Preferences, `.wimport`, Explorer and VS Code
Expand Down
13 changes: 8 additions & 5 deletions src/SQLBI.Whiteboard/BoardSurface.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,6 @@ protected override void OnRender(DrawingContext drawingContext)
return;
}

if (PendingStroke is { Count: > 1 } pending)
{
DrawStroke(drawingContext, pending, PendingStrokeStyle, _camera);
}

foreach (var item in _document.Query(_camera.VisibleWorldBounds))
{
if (item.Id == HiddenObjectId)
Expand Down Expand Up @@ -95,6 +90,14 @@ protected override void OnRender(DrawingContext drawingContext)
}
}

// Over the containers, not under them: the stroke is committed with the
// topmost z-index, so drawing it first made the wet ink disappear behind
// whatever it crossed and reappear only once the pen lifted.
if (PendingStroke is { Count: > 1 } pending)
{
DrawStroke(drawingContext, pending, PendingStrokeStyle, _camera);
}

if (HoveredObjectId is Guid hoveredId &&
hoveredId != SelectedObjectId &&
_document.Objects.FirstOrDefault(item => item.Id == hoveredId) is { } hovered)
Expand Down