Repository navigation
fix(template): cast the update_mask argument to text[] - #85
Merged
Merged
Conversation
The UPDATE queries test each column with '<column>' = any(sqlc.arg(update_mask)). Some sqlc plugins (sqlc-gen-sqlx, used by grpc-rust-template) cannot infer the parameter's type there and need the explicit text[] cast; Go's pgx accepts it either way. Casting in the template lets every downstream template use the generated queries unchanged instead of patching them.
Contributor
Code Metrics Report
Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The generated UPDATE queries test each column with
'<column>' = any(sqlc.arg(update_mask)). sqlc-gen-sqlx, which protoc-contrib/grpc-rust-template uses, can't infer that parameter's type, so grpc-rust-template keeps its own copy of the queries with::text[]added. That's the only difference between its queries and sqlc-contrib/sqlc-go-template's.Casting in the template,
any(sqlc.arg(update_mask)::text[])at all 8 places, lets every downstream template use the generated queries unchanged. Go's pgx accepts the cast with a[]stringargument.Follow-ups
internal/database/query/*.sqland the sqlc code, and run its database suite.Test plan
go vet ./...,go tool ginkgo -r: all suites pass