Skip to content

Fix 1872 rust scala lifetime #2137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
squid-protocol merged 3 commits into from
Aug 22, 2026
Merged

Fix 1872 rust scala lifetime #2137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1fbcdd7
fix(rust,scala): fix args truncation by ignoring lifetime/symbol marks
squid-protocol Aug 22, 2026
1b03ad7
docs: regenerate tri-comparison chart for all languages
squid-protocol Aug 22, 2026
41a5201
Merge main into fix-1872-rust-scala-lifetime
squid-protocol Aug 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .claude/rules/tri-comparison-chart.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
---
name: regenerate-tri-comparison-chart-all
description: Ensure the tri-comparison chart is always regenerated for all languages instead of just the ones being modified.
---

# Always Regenerate Tri-Comparison Chart For All Languages

When regenerating the tri-comparison chart (`tests/tools/tri_comparison_chart.py`) and its ledger to verify fixes, you **MUST ALWAYS** regenerate it for ALL languages, not just the languages that were improved.

To do this, use the `--all` flag:
`python tests/tools/tri_comparison_chart.py --all --write`

This ensures that the final chart accurately reflects the global state of the engine rather than isolating metrics for a single language.
Loading
Loading