fix: skip class extraction for languages with class_start=None - #2188
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
squid-protocol
force-pushed
the
fix/issue-1925-class-start-none
branch
from
August 23, 2026 21:43
0fc865c to
99ab299
Compare
Fixes a bug where languages explicitly opting out of class extraction (class_start: None) were falling back to a generic regex and incorrectly finding classes in embedded snippets (e.g., m4 finding C structs in autoconf tests). Resolves #1925
squid-protocol
force-pushed
the
fix/issue-1925-class-start-none
branch
from
August 23, 2026 21:51
99ab299 to
e213033
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where languages explicitly opting out of class extraction (
class_start: None) were falling back to the generic C-family OOP regex instead of actually skipping extraction.This caused 4 false-positive "classes" in
m4to be identified because it found C structs inside anAC_LANG_PROGRAMmacro argument. The fallback is now only used whenclass_startis actually undefined, not when it is explicitly set toNone.All tests pass, and the tri-comparison ledger has been regenerated (the
m4/class/existence/agree[gitgalaxy]_vs[ctags]discrepancies have disappeared as expected).Resolves #1925