Skip to content

Add explicit error handling for empty LLM responses #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
claude merged 2 commits into from
Sep 4, 2026
Merged

Add explicit error handling for empty LLM responses #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbcee7d
fix: add validation for empty zeroday LLM responses
ssevera1 Sep 4, 2026
842bf6c
fix(review): revert docstring regression and no-op diff, add missing …
github-actions[bot] Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions tests/test_llm_analyzer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,18 @@ def test_empty_narrative_section_is_flagged(analyzer):
assert "Analysis unavailable" in results["executive_summary"]


def test_empty_zeroday_response_records_an_error(analyzer):
anomaly = ZeroDayAnomaly(detector="d", title="t", score=90, description="desc")
with patch(
"urllib.request.urlopen", side_effect=lambda *a, **k: _FakeResponse(_claude_text(""))
):
results = analyzer._analyze_zeroday([anomaly])

assert len(results) == 1
assert "raw_analysis" not in results[0]
assert "empty response" in results[0]["error"]


def test_analyze_single_finding_propagates_failure(analyzer):
with patch("urllib.request.urlopen", side_effect=_http_error(401)):
with pytest.raises(LLMError):
Expand Down