fix: anchor rollback assertion to cascade rollback preflight#12
Merged
Conversation
added 2 commits
June 26, 2026 18:58
The rollback scenario suite only cleared releases and tags at the start, leaving the manifest deploy-history ring intact. In the live fleet the repin push fires its own orchestrate that records a prod deploy in the ring before the suite runs, so the no-target rollback resolved the prior version off that injected entry and reverted prod to the wrong SHA. Wipe the manifest state with cascade reset --state --push before seeding so the seed is genuinely prod's first deploy and the ring's prior is deterministic both standalone and in-fleet. Signed-off-by: Joshua Temple <waitingtables@gmail.com>
The suite asserted prod reverted to the SHA it seeded. That only held by luck: the deploy-on-merge path never pushes to the deploy-history ring, so a no-target rollback reverts to whatever the ring (or manifest git history) already holds, not the suite's seed. The no-target rollback resolves its target with the same resolver the generated workflow's own preflight uses. Anchor the assertion to that resolved target (sha, version, source), keeping the suite deterministic standalone and in-fleet while still exercising the no-target client_payload path. Signed-off-by: Joshua Temple <waitingtables@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The suite asserted a no-target rollback reverts to the seed's recorded sha. That premise is unsound: the deploy-on-merge path does not advance the deploy-history ring (only promote/rollback finalize push a ring snapshot), so the no-target rollback resolves its target from whatever the ring already holds (a stale cross-run entry or a repin-injected deploy), not the suite's seed. It passed standalone by luck and failed in the live fleet after the repin push.
Fix: before firing the no-target repository_dispatch rollback, call
cascade rollback preflight --env prod --json(the exact resolver the generated rollback workflow's preflight uses) to learn the target the rollback will pick, assert it is a real revert (no_op=false, != current), then assert the committed result matches that resolved target plus ref=rollback/prod. Deterministic and immune to ring pollution; still exercises the no-target client_payload path the suite uniquely proves.Validated: reproduced the in-fleet failure, then this fix passed green against a polluted/diverged ring (suite run completed/success including the reconcile gate). actionlint and guardrails clean.