fix(statewrite): route orchestrate and external state writes through WriteManifestState#389
Merged
Merged
Conversation
…WriteManifestState orchestrate writeConfig and external writeManifest re-marshaled the typed CICDFile, dropping any manifest config the running binary does not model (and writeConfig dropped the ci: wrapper). This is the last lossy state-write class after #350/#371: it strips cli_version_sha (added in #384) on the next state commit for a binary that predates it, leaving a pin_mode:sha repo with SHA-pinned workflows but a manifest that no longer declares the pin, which reads as permanent drift and would re-open the setup-cli code-scanning alerts. Route both writers through config.WriteManifestState so only state and latest_release change and all other config, modeled or not, survives verbatim. Closes #372. Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
orchestrate.writeConfigandexternal.writeManifestre-marshaled the typed CICDFile, dropping manifest config the running binary does not model. This is the last lossy state-write class after #350/#371. It stripscli_version_sha(added in #384) on the next state commit, leaving apin_mode: sharepo with SHA-pinned workflows but a manifest missing the pin declaration. That permanent drift fails the drift-check gate (the live fleet's 4env failure) and would re-open the setup-cli alerts on cascade's own repo after its next state write.Fix
Route both writers through
config.WriteManifestState(yaml.Node splice of only state/latest_release), preserving all other config verbatim. New tests assert cli_version_sha, an unmodeled field, the ci wrapper, and no runtime-field leak survive. go test ./... green. Closes #372.