fix(fleet): tag-pin the example repos in the repin instead of SHA-pinning#391
Merged
Merged
Conversation
…ning The repin wrote cli_version_sha into each example repo's manifest and regenerated, SHA-pinning the setup-cli refs. For the one pin_mode:sha repo (4env), a routine state-write then dropped cli_version_sha while the committed workflows stayed SHA-pinned, a permanent drift that failed the drift-check gate every full fleet run. The example repos are ephemeral test pins that do not need SHA-pinning; cascade's own repo keeps its static SHA-pin (which cleared the code-scanning alerts) and the generator SHA-pin path is covered by unit tests. So the repin now deletes any cli_version_sha and regenerates, leaving the example repos tag-pinned and drift-clean. The residual root cause of the field drop is tracked in #390. Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repin wrote cli_version_sha and regenerated, SHA-pinning the example repos' setup-cli refs. For the one pin_mode:sha repo (4env), a routine state-write then dropped cli_version_sha while the workflows stayed SHA-pinned, a permanent drift that failed the drift-check gate every full fleet run. Example repos are ephemeral test pins that do not need SHA-pinning; cascade's own repo keeps its static SHA-pin (the 5 alerts stay fixed) and the generator path is unit-tested. The repin now deletes any cli_version_sha and regenerates, leaving example repos tag-pinned and drift-clean (verified locally: cascade verify reports no drift, regeneration idempotent). Residual root cause tracked in #390. Part of #373.