Update Helm Chart for S3 File Browser v0 - #249
Merged
Merged
Conversation
dklOrdix
requested changes
Jul 22, 2026
Squashed commits: - refactor(frontend): clean up and restructure app - fix: add lint:fix script to package.json - docs: update AGENTS.md to include Material UI icon library usage - refactor(header): move components for header into own directory - chore: dedupe lockfile - fix(sidebar): add hover cursor style to toggle button - chore(types): centralise navigation and auth types - feat(storage): initial Filebrowser UI implementation - refactor(storage): extract service layer and consolidate storage types - update helm chart to include v0 s3 file browser env vars - remove non-overwriting values - undo previous commit c2f988c - various s3 file browser fixes and improvements
dklOrdix
force-pushed
the
feat/s3-file-browser-v0-helm-update
branch
from
July 22, 2026 13:24
d0576ce to
937dae9
Compare
dklOrdix
previously approved these changes
Jul 24, 2026
lfrancke
requested changes
Aug 25, 2026
lfrancke
left a comment
lfrancke
left a comment
Member
There was a problem hiding this comment.
- These new values should be documented in the values.yaml file. We have just started doing that in our other operators as well: https://github.com/stackabletech/hive-operator/pull/753/changes
- I don't really understand why you set defaults for some but not for others. And especially it seems as if we already have defaults in code and this means we need to keep them in sync between Helm & Code now. Can we not remove the Helm defaults and let the code handle all of it?
Co-authored-by: Lars Francke <lars.francke@stackable.tech>
lfrancke
requested changes
Aug 27, 2026
lfrancke
left a comment
lfrancke
left a comment
Member
There was a problem hiding this comment.
Two findings from Claude and one from me: The values are still undocumented.
lfrancke
requested changes
Aug 31, 2026
lfrancke
left a comment
lfrancke
left a comment
Member
There was a problem hiding this comment.
There is one you missed.
And all (or most?) the values are still undocumented in values.yaml. You're already using "(application default)"
lfrancke
approved these changes
Sep 4, 2026
lfrancke
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.