Feat/iframe modularization - #273
Closed
F3l1x1vo wants to merge 4 commits into
Closed
Conversation
Previously the trino and storage browser applications were duplicated under /embed/* routes just to hide the app shell. Instead, a single `?embed=1` query parameter now hides the sidebar and header via the (app) layout, keeping the embed mode sticky across navigations. The /embed route tree, the storage route-context indirection and the trino helper duplication are removed; the embed response headers are now keyed on the query parameter instead of the path prefix.
Collaborator
Author
|
Superseeded by #278 and no longer maintained. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows for exporting Stackable Cockpit inbuilt applications like the Trino SQL Editor and the Storage File Browser as an iframe element for use in other frontends.
Important Note: As noted in
TECH_DEBT.md, there are specifics to be changed when this feature goes into production. You can already see the iframe integration working instatic/embed-demo.html(a static webpage running in the same session as the rest of the Stackable Cockpit frontend) but it would need changes to work outside of that, again which can be found inTECH_DEBT.md. We will have to remove this static webpage when we are ready to merge this PR.Closes #269