S3 File Browser v2

TECH_DEBT.md

@@ -70,14 +70,6 @@ All server-side query state (progress, rows, status) is held in a module-level `
 
 ---
 
-### Single-file download limit
-
-**File:** `src/lib/storage/download.ts`, `src/lib/components/storage/FileExplorer.svelte`
-
-The Download action is intentionally restricted to a single file at a time. Multi-file or folder downloads (e.g. zipping selected items on the fly) are deferred to a future ticket. Until then, the Download button is disabled whenever more than one item is selected and is always disabled for directories.
-
----
-
 ### Completed query results are ephemeral (default 30-minute TTL)
 
 **File:** `src/lib/server/trino/queries.ts:20`
@@ -122,6 +114,14 @@ Mobile viewport tests (393×851, touch-enabled) are excluded from CI runs to red
 
 ## Infrastructure
 
+### Storage search is a bounded provider scan, not an index
+
+**Files:** `src/lib/server/storage/s3-provider.ts`, `src/routes/(app)/api/storage/search/+server.ts`
+
+Bucket-scoped object search recursively lists provider keys and matches paths in process. The 50-result and 10,000-scanned-key caps, plus request abort support, bound resource use for now but can miss later matches in very large buckets. The long-term fix is an optional, provider-aware search index or asynchronously maintained object catalogue.
+
+---
+
 ### No Content Security Policy headers
 
 No CSP headers are set anywhere. This leaves the app exposed to XSS in ways that a strict CSP would mitigate. Should be added in a SvelteKit hook once the app stabilises.
@@ -136,6 +136,14 @@ The dev server accepts requests from any host. This enables DNS rebinding attack
 
 ---
 
+### Archived downloads are sent without Content-Length
+
+**File:** `src/lib/server/storage/download-manifests.ts`
+
+The exact byte size of a streamed ZIP archive is only known after it has been produced, so the server no longer pre-computes or persists an archive size (`computeZipArchiveSize` and the `archive_size` column were removed). Archive part responses are therefore sent chunked without `Content-Length`; browsers show an indeterminate download size for `.zip` files. The download history UI reports the uncompressed payload total instead. Acceptable now because ZIP archives use the STORE method (no compression) and progress display is not critical. Long-term fix, if size reporting is wanted: compute the exact archive length server-side in a single pass before responding, e.g. by streaming to a temp file, at the cost of doubled I/O.
+
+---
+
 ### Archive browsing downloads entire file before parsing
 
 **File:** `src/lib/server/storage/archive.ts`

docker/Dockerfile

@@ -28,7 +28,7 @@ RUN NODEJS_VERSION=$(cat /tmp/.node-version) && \
         *) echo "Unsupported architecture: ${TARGETARCH}" >&2; exit 1 ;; \
     esac && \
     microdnf update -y && \
-    microdnf install -y curl tar gzip && \
+    microdnf install -y curl tar gzip zip && \
     microdnf clean all && \
     curl -fsSL "https://nodejs.org/dist/v${NODEJS_VERSION}/node-v${NODEJS_VERSION}-linux-${NODEJS_ARCH}.tar.gz" \
         | tar -xzf - --strip-components=1 -C /usr/local

e2e/storage/download.spec.ts

@@ -80,4 +80,84 @@ test.describe('Storage S3 — Download', () => {
       await deleteKnownKeys(client, credentials.bucket, cleanupKeys);
     }
   });
+
+  test('downloads up to three selected files individually', async ({ page }, testInfo) => {
+    const credentials = requireGarageCredentials();
+    const client = createS3Client(credentials);
+    const prefix = uniquePrefix(testInfo, 'dl-multiple');
+    const cleanupKeys = ['one.txt', 'two.txt', 'three.txt'].map((name) => `${prefix}${name}`);
+
+    try {
+      await Promise.all(
+        cleanupKeys.map((key) => putTextObject(client, credentials.bucket, key, key))
+      );
+      await connectAndOpenPrefix(page, credentials, prefix);
+      await page.getByRole('button', { name: 'Toggle selection mode' }).click();
+      for (const name of ['one.txt', 'two.txt', 'three.txt']) {
+        await page.getByLabel(`Select ${name}`).check();
+      }
+
+      const downloads: string[] = [];
+      page.on('download', (download) => downloads.push(download.suggestedFilename()));
+      await page.getByRole('button', { name: 'Download', exact: true }).click();
+      await expect.poll(() => downloads.sort()).toEqual(['one.txt', 'three.txt', 'two.txt']);
+      expect(downloads.sort()).toEqual(['one.txt', 'three.txt', 'two.txt']);
+    } finally {
+      await deleteKnownKeys(client, credentials.bucket, cleanupKeys);
+    }
+  });
+
+  test('archives a selection larger than three files', async ({ page }, testInfo) => {
+    const credentials = requireGarageCredentials();
+    const client = createS3Client(credentials);
+    const prefix = uniquePrefix(testInfo, 'dl-archive');
+    const cleanupKeys = ['one.txt', 'two.txt', 'three.txt', 'four.txt'].map(
+      (name) => `${prefix}${name}`
+    );
+
+    try {
+      await Promise.all(
+        cleanupKeys.map((key) => putTextObject(client, credentials.bucket, key, key))
+      );
+      await connectAndOpenPrefix(page, credentials, prefix);
+      await page.getByRole('button', { name: 'Toggle selection mode' }).click();
+      for (const name of ['one.txt', 'two.txt', 'three.txt', 'four.txt']) {
+        await page.getByLabel(`Select ${name}`).check();
+      }
+
+      const [download] = await Promise.all([
+        page.waitForEvent('download'),
+        page.getByRole('button', { name: 'Download', exact: true }).click()
+      ]);
+      expect(download.suggestedFilename()).toMatch(/\.zip$/);
+    } finally {
+      await deleteKnownKeys(client, credentials.bucket, cleanupKeys);
+    }
+  });
+
+  test('downloads a folder via its context menu when not in selection mode', async ({
+    page
+  }, testInfo) => {
+    const credentials = requireGarageCredentials();
+    const client = createS3Client(credentials);
+    const prefix = uniquePrefix(testInfo, 'dl-folder');
+    const cleanupKeys = [`${prefix}folder1/one.txt`, `${prefix}folder1/two.txt`];
+
+    try {
+      await Promise.all(
+        cleanupKeys.map((key) => putTextObject(client, credentials.bucket, key, key))
+      );
+      await connectAndOpenPrefix(page, credentials, prefix);
+
+      await rowByName(page, 'folder1').click({ button: 'right' });
+
+      const downloadBtn = page.getByRole('menuitem', { name: 'Download' });
+      await expect(downloadBtn).not.toHaveAttribute('disabled');
+
+      const [download] = await Promise.all([page.waitForEvent('download'), downloadBtn.click()]);
+      expect(download.suggestedFilename()).toMatch(/\.zip$/);
+    } finally {
+      await deleteKnownKeys(client, credentials.bucket, cleanupKeys);
+    }
+  });
 });

e2e/storage/file-operations.spec.ts

@@ -353,7 +353,8 @@ test.describe('Storage S3 — File Operations', () => {
     const prefix = uniquePrefix(testInfo, 'kb-cut-paste');
     const srcKey = `${prefix}cutsrc/`;
     const srcFile = `${srcKey}cut-kb.txt`;
-    const cleanupKeys = [srcFile];
+    const destFile = `${prefix}cut-kb.txt`;
+    const cleanupKeys = [srcFile, destFile];
 
     try {
       await putDirectoryMarker(client, credentials.bucket, srcKey);
@@ -379,7 +380,7 @@ test.describe('Storage S3 — File Operations', () => {
       await page.waitForTimeout(1000);
 
       // File should exist at destination
-      expect(await objectExists(client, credentials.bucket, `${prefix}cut-kb.txt`)).toBe(true);
+      expect(await objectExists(client, credentials.bucket, destFile)).toBe(true);
     } finally {
       await deleteKnownKeys(client, credentials.bucket, cleanupKeys);
     }

e2e/storage/helpers.ts

@@ -159,6 +159,7 @@ export async function connectAndOpenPrefix(
  */
 export async function waitForObjectsLoaded(page: Page) {
   await waitForHydration(page);
+  await page.getByLabel('Loading…').waitFor({ state: 'hidden', timeout: 15_000 });
   await page
     .locator('tbody tr')
     .or(page.getByText('This bucket is empty'))

e2e/storage/search.spec.ts

@@ -0,0 +1,178 @@
+import { test, expect } from '@playwright/test';
+import {
+  createS3Client,
+  hasGarageCredentials,
+  requireGarageCredentials
+} from '../support/garage.js';
+import {
+  bucketRoute,
+  connectAndOpenPrefix,
+  connectToStorage,
+  deleteKnownKeys,
+  putDirectoryMarker,
+  putTextObject,
+  uniquePrefix
+} from './helpers.js';
+
+test.describe('Storage Search', () => {
+  test.use({ locale: 'en-US' });
+
+  test.beforeEach(() => {
+    test.skip(
+      !hasGarageCredentials(),
+      'Skipped: no s3-config.json found (requires a running Garage instance)'
+    );
+  });
+
+  test('searches the current bucket, runs parallel sessions, and opens matching results', async ({
+    page
+  }, testInfo) => {
+    const credentials = requireGarageCredentials();
+    const client = createS3Client(credentials);
+    const prefix = uniquePrefix(testInfo, 'search');
+    const directory = `${prefix}reports/`;
+    const file = `${directory}final-report.txt`;
+
+    try {
+      await putDirectoryMarker(client, credentials.bucket, directory);
+      await putTextObject(client, credentials.bucket, file, 'search preview');
+      await connectToStorage(page, credentials);
+
+      await page.getByRole('button', { name: 'Open search' }).first().click();
+      await page.getByLabel('Search query').fill('report');
+      await page.getByRole('button', { name: 'Search', exact: true }).click();
+
+      await expect(page.getByText(/2 results/)).toBeVisible();
+      await page.getByRole('button', { name: /reports.*\/reports\// }).click();
+      await expect(page).toHaveURL(bucketRoute(credentials.bucket, directory));
+
+      await page.getByRole('button', { name: 'Open search' }).first().click();
+      await page.getByRole('button', { name: 'Parallel search' }).click();
+      await expect(page.getByRole('navigation', { name: 'Search sessions' })).toBeVisible();
+      await page.getByLabel('Search query').fill('final-report');
+      await page.getByRole('button', { name: 'Search', exact: true }).click();
+      await page
+        .getByRole('button', { name: /final-report\.txt.*\/reports\/final-report\.txt/ })
+        .click();
+      const previewDialog = page.getByRole('dialog').filter({ hasText: 'final-report.txt' });
+      await expect(previewDialog).toContainText('final-report.txt');
+      await previewDialog.getByLabel('Close', { exact: true }).click();
+    } finally {
+      await deleteKnownKeys(client, credentials.bucket, [directory, file]);
+    }
+  });
+
+  test('searches all buckets from the landing page', async ({ page }, testInfo) => {
+    const credentials = requireGarageCredentials();
+    const client = createS3Client(credentials);
+    const prefix = uniquePrefix(testInfo, 'landing-search');
+    const file = `${prefix}landing-report.txt`;
+
+    try {
+      await putTextObject(client, credentials.bucket, file, 'landing search');
+      await connectToStorage(page, credentials);
+
+      await page.getByRole('button', { name: 'Open search' }).first().click();
+      await page.getByLabel('Search query').fill('landing-report');
+      await page.getByRole('button', { name: 'Search', exact: true }).click();
+
+      await expect(page.getByRole('button', { name: 'landing-report.txt' })).toBeVisible();
+    } finally {
+      await deleteKnownKeys(client, credentials.bucket, [file]);
+    }
+  });
+
+  test('paginates search results', async ({ page }, testInfo) => {
+    const credentials = requireGarageCredentials();
+    const client = createS3Client(credentials);
+    const prefix = uniquePrefix(testInfo, 'paginate-search');
+    const keys: string[] = [];
+
+    try {
+      for (let index = 1; index <= 30; index += 1) {
+        const key = `${prefix}report-${String(index).padStart(2, '0')}.txt`;
+        keys.push(key);
+        await putTextObject(client, credentials.bucket, key, `report ${index}`);
+      }
+      await connectToStorage(page, credentials);
+
+      await page.getByRole('button', { name: 'Open search' }).first().click();
+      await page.getByLabel('Search query').fill('report-');
+      await page.getByRole('button', { name: 'Search', exact: true }).click();
+      await page.getByLabel('Items per page').selectOption('25');
+
+      await expect(page.getByText('Page 1', { exact: true })).toBeVisible();
+      await expect(page.getByRole('button', { name: 'report-01.txt' })).toBeVisible();
+      await expect(page.getByRole('button', { name: 'report-26.txt' })).not.toBeVisible();
+
+      await page.getByRole('button', { name: 'Next page' }).click();
+      await expect(page.getByText('Page 2', { exact: true })).toBeVisible();
+      await expect(page.getByRole('button', { name: 'report-26.txt' })).toBeVisible();
+      await expect(page.getByRole('button', { name: 'report-01.txt' })).not.toBeVisible();
+    } finally {
+      await deleteKnownKeys(client, credentials.bucket, keys);
+    }
+  });
+
+  test('filters and selects buckets via the bucket dropdown', async ({ page }, testInfo) => {
+    const credentials = requireGarageCredentials();
+    const client = createS3Client(credentials);
+    const prefix = uniquePrefix(testInfo, 'bucket-scope');
+    const file = `${prefix}scoped-report.txt`;
+
+    try {
+      await putTextObject(client, credentials.bucket, file, 'scoped search');
+      await connectToStorage(page, credentials);
+
+      await page.getByRole('button', { name: 'Open search' }).first().click();
+
+      const trigger = page.getByRole('button', { name: 'all buckets', exact: true });
+      await expect(trigger).toBeVisible();
+      await trigger.click();
+
+      await page.getByLabel('Filter buckets').fill(credentials.bucket);
+      await page
+        .getByRole('button', { name: `Include ${credentials.bucket} in search`, exact: true })
+        .click();
+      await expect(
+        page.getByRole('button', { name: credentials.bucket, exact: true })
+      ).toBeVisible();
+
+      await page.getByLabel('Search query').fill('scoped-report');
+      await page.getByRole('button', { name: 'Search', exact: true }).click();
+      await expect(page.getByRole('button', { name: 'scoped-report.txt' })).toBeVisible();
+    } finally {
+      await deleteKnownKeys(client, credentials.bucket, [file]);
+    }
+  });
+
+  test('shows recent searches in the recent view and reuses one', async ({ page }, testInfo) => {
+    const credentials = requireGarageCredentials();
+    const client = createS3Client(credentials);
+    const prefix = uniquePrefix(testInfo, 'recent');
+    const file = `${prefix}recent-report.txt`;
+
+    try {
+      await putTextObject(client, credentials.bucket, file, 'recent search');
+      await connectAndOpenPrefix(page, credentials, prefix);
+
+      await page.getByRole('button', { name: 'Open search' }).first().click();
+      await page.getByLabel('Search query').fill('recent-report');
+      await page.getByRole('button', { name: 'Search', exact: true }).click();
+      await expect(page.getByRole('button', { name: 'recent-report.txt' }).first()).toBeVisible();
+
+      await page.getByRole('button', { name: 'Close search' }).click();
+      await page.getByRole('button', { name: 'Open search' }).first().click();
+      await page.getByRole('tab', { name: 'Recent', exact: true }).click();
+      await expect(page.getByRole('button', { name: /recent-report/ }).first()).toBeVisible();
+
+      await page
+        .getByRole('button', { name: /recent-report/ })
+        .first()
+        .click();
+      await expect(page.getByLabel('Search query')).toHaveValue('recent-report');
+    } finally {
+      await deleteKnownKeys(client, credentials.bucket, [file]);
+    }
+  });
+});

eslint.config.js

@@ -62,7 +62,8 @@ export default ts.config(
             'menu-disabled',
             'tab-active',
             'tab-strip',
-            'preview-scroll'
+            'preview-scroll',
+            'modal-top-search'
           ]
         }
       ]