fix(trino): Bugfixes & QoL changes - #311
Open
labrenbe wants to merge 8 commits into
Open
Conversation
dervoeti
requested changes
Sep 8, 2026
| const reason = | ||
| name === 'TimeoutError' || name === 'AbortError' | ||
| ? 'Connection test timed out' | ||
| : `Could not connect to Trino: ${detail}`; |
Member
There was a problem hiding this comment.
I think we should not return detail here. The user could try to connect to whatever cluster-internal service here and probably see the raw response from it this way.
| options: { user: string; catalog?: string; schema?: string } | ||
| options: { user: string; catalog?: string; schema?: string; signal?: AbortSignal } | ||
| ): Promise<TrinoQueryResult> { | ||
| const headers: Record<string, string> = { |
Member
There was a problem hiding this comment.
We should probably also use headersForUser here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-feedback fixes and QoL improvements for the Trino module.
Fixed
DELETE nextUriinstead of the kill-query-gatedDELETE /v1/query/{id}.X-Trino-Userwhen impersonation is enabled (previously ran as the service principal).SELECT 1, 10 s timeout) before storing, instead of always reporting success.Added
trino.publicUrl: separate browser-facing URL for the "View in Trino" deep link (falls back totrino.url); wired through the Helm chart.Tests
cancelViaUri, impersonation headers,AbortSignalforwarding,resolveTrinoPublicUrl, row-limit cancel.