Skip to content

feat: Adds a warning when a defined object override was not applied - #1264

Merged
sweb merged 8 commits into
mainfrom
feat/object-override-warning
Aug 24, 2026
Merged

feat: Adds a warning when a defined object override was not applied#1264
sweb merged 8 commits into
mainfrom
feat/object-override-warning

Conversation

@sweb

@sweb sweb commented Aug 14, 2026

Copy link
Copy Markdown
Member

Description

Adds a warning when a defined object override was not applied.

Optional: Adds the base namespace as default when the namespace of the override is not provided I removed this as it seems too much of a change.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@sweb
sweb force-pushed the feat/object-override-warning branch from 6bf58f7 to 2f10879 Compare August 14, 2026 09:40
@sweb sweb changed the title Feat/object override warning feat: Adds a warning when a defined object override was not applied Aug 14, 2026
@sweb
sweb force-pushed the feat/object-override-warning branch from 2f10879 to 2349216 Compare August 14, 2026 14:21
@sweb
sweb marked this pull request as ready for review August 14, 2026 14:23
@sweb
sweb force-pushed the feat/object-override-warning branch 2 times, most recently from d9924ba to 5e5d619 Compare August 18, 2026 05:53
@sweb
sweb force-pushed the feat/object-override-warning branch from 5e5d619 to d073166 Compare August 18, 2026 06:01
@sweb sweb self-assigned this Aug 18, 2026
@sweb sweb moved this to Development: Waiting for Review in Stackable Engineering Aug 18, 2026
@Maleware
Maleware self-requested a review August 18, 2026 07:41
@Maleware Maleware moved this from Development: Waiting for Review to Refinement: In Progress in Stackable Engineering Aug 18, 2026
@Maleware Maleware moved this from Refinement: In Progress to Development: In Review in Stackable Engineering Aug 18, 2026

@Maleware Maleware left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to the comment, LGTM thanks!

Comment thread crates/stackable-operator/src/cluster_resources.rs
Comment thread crates/stackable-operator/src/cluster_resources.rs
Comment thread crates/stackable-operator/CHANGELOG.md Outdated
@sweb

sweb commented Aug 24, 2026

Copy link
Copy Markdown
Member Author

@Techassi could you take another look?

Comment thread crates/stackable-operator/src/cluster_resources.rs
Co-authored-by: Techassi <git@techassi.dev>
Techassi
Techassi previously approved these changes Aug 24, 2026
@sweb
sweb added this pull request to the merge queue Aug 24, 2026
Merged via the queue into main with commit c296c8a Aug 24, 2026
5 checks passed
@sweb
sweb deleted the feat/object-override-warning branch August 24, 2026 13:16
@Techassi Techassi moved this from Development: In Review to Development: Done in Stackable Engineering Aug 31, 2026
@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Aug 31, 2026
@lfrancke

lfrancke commented Sep 1, 2026

Copy link
Copy Markdown
Member

I know this is in operator-rs but once it lands in the operators...should this have release notes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Acceptance: In Progress

Development

Successfully merging this pull request may close these issues.

4 participants