feat: Generate the Artifact Hub CRD annotation from extra/crds.yaml - #622
Merged
Conversation
This is derived from extra/crds.yaml and ends up in Chart.yaml.
Member
Author
|
If you like I can create this as a test PR in one repo first. |
NickLarsenNZ
reviewed
Aug 4, 2026
Addresses review feedback: the recipe was one long line, so it was not obvious that it reads extra/crds.yaml and writes Chart.yaml. CRD_ANNOTATION_READ and CRD_ANNOTATION_WRITE are now separate, each with its own comment. Still a single shell command: the env-var prefix is needed because the value is multi-line and reaches yq via strenv.
Techassi
reviewed
Aug 4, 2026
NickLarsenNZ
approved these changes
Aug 5, 2026
NickLarsenNZ
left a comment
NickLarsenNZ
left a comment
Member
There was a problem hiding this comment.
LGTM.
The yq statements could b easier to read on multiple lines but that can be done later (ie: when it bugs me enough, I'll do it).
NickLarsenNZ
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
lfrancke
enabled auto-merge
August 5, 2026 22:48
sbernauer
moved this from Development: In Review
to Development: Done
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is derived from extra/crds.yaml and ends up in Chart.yaml.