Fix find_publication_for_distribution - #78
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies plugins/filter/filters.py to sort the publications list using sort_publications before iterating to find a match. The reviewer identified that sorting the entire list is inefficient and potentially error-prone if some publications lack a valid repository_version. They recommend filtering the publications by repository_href first before sorting, and provided a code suggestion to address this.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Sorting the publication list so that the most recent are first fixes creation of some distributions in stackhpc-release-train.
Alex-Welsh
left a comment
Alex-Welsh
left a comment
There was a problem hiding this comment.
@priteau do you want to bump the collection version in the same PR or make a new one for it?
2 participants
Sorting the publication list so that the most recent are first fixes creation of some distributions in stackhpc-release-train.