fix(fog): scope V58A3 command quirks to libdeye - #65
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
==========================================
+ Coverage 93.31% 93.40% +0.08%
==========================================
Files 7 7
Lines 838 849 +11
Branches 85 88 +3
==========================================
+ Hits 782 793 +11
Misses 25 25
Partials 31 31 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move the DYD-V58A3 Fog command workarounds into libdeye so integrations do not need product-specific logic.
The V58A3 now:
Power=1in non-empty partial updates while powered onModewhen a power-on update containsPower=1SetHumidityfrom auto-mode updatesThese transformations preserve the behavior verified in #64 and stackia/ha-deye-dehumidifier#103 while limiting it to the V58A3. U20A3, U20Air, and generic Fog products retain their existing behavior. Input property dictionaries are copied before normalization.
Validation
.venv/bin/pytest— 113 passed.venv/bin/mypy ..venv/bin/pre-commit run --all-filesgit diff --check