Skip to content

fix(fog): scope V58A3 command quirks to libdeye - #65

Merged
stackia merged 1 commit into
mainfrom
codex/v58a3-fog-command-quirks
Aug 3, 2026
Merged

fix(fog): scope V58A3 command quirks to libdeye#65
stackia merged 1 commit into
mainfrom
codex/v58a3-fog-command-quirks

Conversation

@stackia

@stackia stackia commented Aug 3, 2026

Copy link
Copy Markdown
Owner

Summary

Move the DYD-V58A3 Fog command workarounds into libdeye so integrations do not need product-specific logic.

The V58A3 now:

  • preserves Power=1 in non-empty partial updates while powered on
  • re-asserts Mode when a power-on update contains Power=1
  • omits SetHumidity from auto-mode updates

These transformations preserve the behavior verified in #64 and stackia/ha-deye-dehumidifier#103 while limiting it to the V58A3. U20A3, U20Air, and generic Fog products retain their existing behavior. Input property dictionaries are copied before normalization.

Validation

  • .venv/bin/pytest — 113 passed
  • .venv/bin/mypy .
  • .venv/bin/pre-commit run --all-files
  • git diff --check

@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.40%. Comparing base (61756cf) to head (652fbc4).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
+ Coverage   93.31%   93.40%   +0.08%     
==========================================
  Files           7        7              
  Lines         838      849      +11     
  Branches       85       88       +3     
==========================================
+ Hits          782      793      +11     
  Misses         25       25              
  Partials       31       31              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@stackia
stackia marked this pull request as ready for review August 3, 2026 09:35
@stackia
stackia merged commit 9ff60ed into main Aug 3, 2026
4 checks passed
@stackia
stackia deleted the codex/v58a3-fog-command-quirks branch August 3, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant