fix(mongodbflex): add regex to username validation#1603
Open
j1n-o9r wants to merge 2 commits into
Open
Conversation
j1n-o9r
marked this pull request as ready for review
July 22, 2026 12:54
j1n-o9r
enabled auto-merge (squash)
July 22, 2026 12:54
rubenhoenle
reviewed
Jul 22, 2026
|
|
||
| func configResources(version, backupSchedule, snapshotRetentionDays string) string { | ||
| var userResourceInvalidName = map[string]string{ | ||
| "username": "-invalid-user-name", |
Member
There was a problem hiding this comment.
Can be unit-tested, no need to have this in an acceptance test.
Member
There was a problem hiding this comment.
See e.g.
rubenhoenle
requested changes
Jul 22, 2026
j1n-o9r
force-pushed
the
fix/STACKITTPR-679-mongodbflex-username-validation
branch
2 times, most recently
from
July 22, 2026 14:29
2e48ebc to
4b3d235
Compare
j1n-o9r
force-pushed
the
fix/STACKITTPR-679-mongodbflex-username-validation
branch
from
July 22, 2026 16:22
4b3d235 to
59144dd
Compare
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
rubenhoenle
reviewed
Jul 23, 2026
| instanceId := uuid.NewString() | ||
| tfConfig := fmt.Sprintf(` | ||
| provider "stackit" { | ||
| mongodbflex_custom_endpoint = "http://localhost:12345" |
Member
There was a problem hiding this comment.
is that custom endpoint needed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See #683 for details.
relates to STACKITTPR-679.
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)