Skip to content

Feat/sqlserverflex encryption support#1604

Open
SerseusWasTaken wants to merge 4 commits into
mainfrom
feat/sqlserverflex-encryption-support
Open

Feat/sqlserverflex encryption support#1604
SerseusWasTaken wants to merge 4 commits into
mainfrom
feat/sqlserverflex-encryption-support

Conversation

@SerseusWasTaken

Copy link
Copy Markdown
Contributor

Description

Adds encryption support and two missing read-only fields

relates to STACKITTPR-756

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@SerseusWasTaken
SerseusWasTaken requested a review from a team as a code owner July 22, 2026 13:01
@SerseusWasTaken
SerseusWasTaken force-pushed the feat/sqlserverflex-encryption-support branch 2 times, most recently from f46afe2 to fc04fc3 Compare July 22, 2026 13:06
Comment thread stackit/internal/services/sqlserverflex/instance/datasource.go Outdated
Comment thread stackit/internal/services/sqlserverflex/instance/resource.go Outdated
Comment thread stackit/internal/services/sqlserverflex/instance/resource.go Outdated
Comment thread stackit/internal/services/sqlserverflex/instance/resource.go Outdated
Comment thread stackit/internal/services/sqlserverflex/sqlserverflex_acc_test.go Outdated
Comment thread stackit/internal/services/sqlserverflex/sqlserverflex_acc_test.go Outdated
Comment thread stackit/internal/services/sqlserverflex/sqlserverflex_acc_test.go
Comment thread stackit/internal/services/sqlserverflex/testdata/resource-max.tf Outdated
Comment thread stackit/internal/services/sqlserverflex/instance/datasource.go Outdated
Comment thread stackit/internal/services/sqlserverflex/instance/resource.go Outdated
@SerseusWasTaken
SerseusWasTaken force-pushed the feat/sqlserverflex-encryption-support branch from 7277295 to 3dbdceb Compare July 23, 2026 08:32
Comment thread stackit/internal/services/sqlserverflex/sqlserverflex_acc_test.go Outdated
@SerseusWasTaken
SerseusWasTaken force-pushed the feat/sqlserverflex-encryption-support branch from 3dbdceb to 3c477aa Compare July 23, 2026 11:20
@SerseusWasTaken
SerseusWasTaken force-pushed the feat/sqlserverflex-encryption-support branch from 3c477aa to 42431b7 Compare July 23, 2026 11:25
@github-actions

Copy link
Copy Markdown

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sqlserverflex 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sqlserverflex/instance 33.98% (+0.18%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sqlserverflex/instance/datasource.go 0.00% (ø) 51 0 51
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sqlserverflex/instance/resource.go 37.69% (+0.05%) 467 (+18) 176 (+7) 291 (+11) 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sqlserverflex/instance/resource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sqlserverflex/sqlserverflex_acc_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sqlserverflex/sqlserverflex_private_preview_acc_test.go

@marceljk marceljk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works as expected :)

@@ -39,6 +39,7 @@ resource "stackit_sqlserverflex_instance" "example" {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you quickly update the example here. I missed that during the migration from v2 to v3 and I think it would be better to provide here an example which doesn't return any warnings.

resource "stackit_sqlserverflex_instance" "instance" {
  project_id      = "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx"
  name            = "example-instance"
  flavor_id       = "4.16-Single"
  backup_schedule = "0 0 * * *"
  network = {
    acl = ["XXX.XXX.XXX.X/XX", "XX.XXX.XX.X/XX"]
  }
  storage = {
    class = "premium-perf2-stackit"
    size  = 5
  }
  retention_days = 32
  version        = "2022"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants