feat(postgresflex): migrate postgresflex resources from v2 to v3 API#1607
Open
marceljk wants to merge 3 commits into
Open
feat(postgresflex): migrate postgresflex resources from v2 to v3 API#1607marceljk wants to merge 3 commits into
marceljk wants to merge 3 commits into
Conversation
marceljk
force-pushed
the
feat/STACKITTPR-734-postgresflex-v3
branch
from
July 22, 2026 16:08
ff7b860 to
bb8a1fd
Compare
relates to STACKITTPR-734
marceljk
force-pushed
the
feat/STACKITTPR-734-postgresflex-v3
branch
from
July 23, 2026 06:41
bb8a1fd to
24d6be6
Compare
marceljk
commented
Jul 23, 2026
| "github.com/hashicorp/terraform-plugin-framework/types" | ||
| "github.com/stackitcloud/stackit-sdk-go/core/oapierror" | ||
| postgresflex "github.com/stackitcloud/stackit-sdk-go/services/postgresflex/v2api" | ||
| postgresflex "github.com/stackitcloud/stackit-sdk-go/services/postgresflex/v3beta1api" |
Contributor
Author
There was a problem hiding this comment.
must be updated to v3api before merge
SerseusWasTaken
left a comment
SerseusWasTaken
left a comment
Contributor
There was a problem hiding this comment.
Some questions and nitpicks, but looks really clean overall 🙂
Merging this branch changes the coverage (3 decrease, 2 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
| Description: descriptions["retention_days"], | ||
| Optional: true, | ||
| Computed: true, | ||
| }, |
Contributor
There was a problem hiding this comment.
We can add validation here since the api docs state that retention should be a value between 32 and 90
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
relates to STACKITTPR-734
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)