Skip to content

test(mecatui): fix Converse refresh and queued prompt flakes - #2605

Merged
jbeda merged 1 commit into
mainfrom
fix/tui-test-flakes
Oct 29, 2026
Merged

jbeda merged 1 commit into
mainfrom
fix/tui-test-flakes

Conversation

@jbeda

@jbeda jbeda commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Summary

Fix two terminal-client test flakes as a small test-only batch:

No production changes, sleeps, retries, or timeout increases.

Verification

  • task test
  • task test:race
  • task lint
  • go run ./cmd/mecademo — tool call, permission ask/approval, and final result verified
  • go test -race ./cmd/mecatui/client -run 'Test(Converse|StreamReplaysAFrameSentAfterTheRejection)' -count=100 -cpu=1,2,4 -timeout=5m
  • go test -race ./cmd/mecatui/ui -run '^TestQueuedPromptAutoSendsProgram$' -count=100 -cpu=1,2,4 -timeout=5m
  • Mutation check: restoring strict send-error handling fails every deterministic failed-refresh regression case; restoring the fix passes.
  • Four-axis review: no blockers or important findings. One advisory notes that the deterministic auth regression uses a fake transport, supplemented by existing real-gRPC integration coverage.

API compatibility

No wire, Go production API, or stored-data changes. Only test fixtures, synchronization, and assertions change; API major and feature identifiers are unchanged, and no client/server upgrade coordination is required.

Wait for recorded prompt sends before shutting down the queued-prompt test, and read the authoritative auth status when gRPC Send returns EOF. Add a deterministic failed-refresh ordering regression and strengthen refresh assertions.

Fixes #2580

Fixes #2582

Co-authored-by: Mecatl <noreply@mecatl.dev>
@jbeda
jbeda merged commit 0798b9f into main Oct 29, 2026
40 checks passed
@jbeda
jbeda deleted the fix/tui-test-flakes branch October 29, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant