chore: lexical upgrade

package.json

@@ -45,7 +45,9 @@
     "@types/react-native-vector-icons/@types/react": "17.0.2",
     "@types/react-native/@types/react": "17.0.2",
     "@types/hoist-non-react-statics/@types/react": "17.0.2",
-    "node-abi": "^4.2.0"
+    "node-abi": "^4.2.0",
+    "@typescript-eslint/eslint-plugin": "8.32.1",
+    "@typescript-eslint/parser": "8.32.1"
   },
   "dependencies": {
     "@standardnotes/snjs": "workspace:*"
@@ -61,11 +63,11 @@
     "@lerna-lite/run": "^4.10.5",
     "@lerna-lite/version": "^4.10.5",
     "@standardnotes/config": "^2.4.3",
-    "@typescript-eslint/eslint-plugin": "^6.2.0",
-    "@typescript-eslint/parser": "^6.2.0",
+    "@typescript-eslint/eslint-plugin": "^8.32.0",
+    "@typescript-eslint/parser": "^8.32.0",
     "changelog-parser": "^2.8.1",
     "css-loader": "^6.8.1",
-    "eslint": "^8.45.0",
+    "eslint": "^8.57.0",
     "eslint-plugin-prettier": "^5.0.0",
     "lint-staged": "^13.2.3",
     "npm-check-updates": "^16.10.17",

packages/api/package.json

@@ -32,7 +32,7 @@
     "eslint-plugin-prettier": "*",
     "jest": "^29.3.1",
     "ts-jest": "^29.0.3",
-    "typescript": "*"
+    "typescript": "5.8.3"
   },
   "dependencies": {
     "@standardnotes/common": "^1.50.0",

packages/api/src/Domain/Client/Auth/AuthApiService.ts

@@ -37,7 +37,7 @@ export class AuthApiService implements AuthApiServiceInterface {
       })
 
       return response
-    } catch (error) {
+    } catch {
       throw new ApiCallError(ErrorMessage.GenericFail)
     } finally {
       this.operationsInProgress.set(AuthApiOperations.GenerateRecoveryCodes, false)
@@ -64,7 +64,7 @@ export class AuthApiService implements AuthApiServiceInterface {
       })
 
       return response
-    } catch (error) {
+    } catch {
       throw new ApiCallError(ErrorMessage.GenericFail)
     } finally {
       this.operationsInProgress.set(AuthApiOperations.GetRecoveryKeyParams, false)
@@ -95,7 +95,7 @@ export class AuthApiService implements AuthApiServiceInterface {
       })
 
       return response
-    } catch (error) {
+    } catch {
       throw new ApiCallError(ErrorMessage.GenericFail)
     } finally {
       this.operationsInProgress.set(AuthApiOperations.SignInWithRecoveryCodes, false)

packages/api/src/Domain/Client/Authenticator/AuthenticatorApiService.ts

@@ -31,7 +31,7 @@ export class AuthenticatorApiService implements AuthenticatorApiServiceInterface
       const response = await this.authenticatorServer.list({})
 
       return response
-    } catch (error) {
+    } catch {
       throw new ApiCallError(ErrorMessage.GenericFail)
     } finally {
       this.operationsInProgress.set(AuthenticatorApiOperations.List, false)
@@ -51,7 +51,7 @@ export class AuthenticatorApiService implements AuthenticatorApiServiceInterface
       })
 
       return response
-    } catch (error) {
+    } catch {
       throw new ApiCallError(ErrorMessage.GenericFail)
     } finally {
       this.operationsInProgress.set(AuthenticatorApiOperations.Delete, false)
@@ -69,7 +69,7 @@ export class AuthenticatorApiService implements AuthenticatorApiServiceInterface
       const response = await this.authenticatorServer.generateRegistrationOptions()
 
       return response
-    } catch (error) {
+    } catch {
       throw new ApiCallError(ErrorMessage.GenericFail)
     } finally {
       this.operationsInProgress.set(AuthenticatorApiOperations.GenerateRegistrationOptions, false)
@@ -95,7 +95,7 @@ export class AuthenticatorApiService implements AuthenticatorApiServiceInterface
       })
 
       return response
-    } catch (error) {
+    } catch {
       throw new ApiCallError(ErrorMessage.GenericFail)
     } finally {
       this.operationsInProgress.set(AuthenticatorApiOperations.VerifyRegistrationResponse, false)
@@ -117,7 +117,7 @@ export class AuthenticatorApiService implements AuthenticatorApiServiceInterface
       })
 
       return response
-    } catch (error) {
+    } catch {
       throw new ApiCallError(ErrorMessage.GenericFail)
     } finally {
       this.operationsInProgress.set(AuthenticatorApiOperations.GenerateAuthenticationOptions, false)

packages/api/src/Domain/Client/Revision/RevisionApiService.ts

@@ -29,7 +29,7 @@ export class RevisionApiService implements RevisionApiServiceInterface {
       })
 
       return response
-    } catch (error) {
+    } catch {
       throw new ApiCallError(ErrorMessage.GenericFail)
     } finally {
       this.operationsInProgress.set(RevisionApiOperations.List, false)
@@ -50,7 +50,7 @@ export class RevisionApiService implements RevisionApiServiceInterface {
       })
 
       return response
-    } catch (error) {
+    } catch {
       throw new ApiCallError(ErrorMessage.GenericFail)
     } finally {
       this.operationsInProgress.set(RevisionApiOperations.Get, false)
@@ -71,7 +71,7 @@ export class RevisionApiService implements RevisionApiServiceInterface {
       })
 
       return response
-    } catch (error) {
+    } catch {
       throw new ApiCallError(ErrorMessage.GenericFail)
     } finally {
       this.operationsInProgress.set(RevisionApiOperations.Delete, false)

packages/api/src/Domain/Client/Subscription/SubscriptionApiService.ts

@@ -43,7 +43,7 @@ export class SubscriptionApiService implements SubscriptionApiServiceInterface {
       })
 
       return response
-    } catch (error) {
+    } catch {
       throw new ApiCallError(ErrorMessage.GenericFail)
     } finally {
       this.operationsInProgress.set(SubscriptionApiOperations.ListingInvites, false)
@@ -64,7 +64,7 @@ export class SubscriptionApiService implements SubscriptionApiServiceInterface {
       })
 
       return response
-    } catch (error) {
+    } catch {
       throw new ApiCallError(ErrorMessage.GenericFail)
     } finally {
       this.operationsInProgress.set(SubscriptionApiOperations.CancelingInvite, false)
@@ -85,7 +85,7 @@ export class SubscriptionApiService implements SubscriptionApiServiceInterface {
       })
 
       return response
-    } catch (error) {
+    } catch {
       throw new ApiCallError(ErrorMessage.GenericFail)
     } finally {
       this.operationsInProgress.set(SubscriptionApiOperations.Inviting, false)
@@ -105,7 +105,7 @@ export class SubscriptionApiService implements SubscriptionApiServiceInterface {
       })
 
       return response
-    } catch (error) {
+    } catch {
       throw new ApiCallError(ErrorMessage.GenericFail)
     } finally {
       this.operationsInProgress.set(SubscriptionApiOperations.AcceptingInvite, false)

packages/api/src/Domain/Client/User/UserApiService.ts

@@ -44,7 +44,7 @@ export class UserApiService implements UserApiServiceInterface {
       this.unlockOperation(UserApiOperations.DeletingAccount)
 
       return response
-    } catch (error) {
+    } catch {
       throw new ApiCallError(ErrorMessage.GenericFail)
     }
   }
@@ -64,7 +64,7 @@ export class UserApiService implements UserApiServiceInterface {
       this.unlockOperation(UserApiOperations.SubmittingRequest)
 
       return response
-    } catch (error) {
+    } catch {
       throw new ApiCallError(ErrorMessage.GenericFail)
     }
   }
@@ -91,7 +91,7 @@ export class UserApiService implements UserApiServiceInterface {
       this.unlockOperation(UserApiOperations.Registering)
 
       return response
-    } catch (error) {
+    } catch {
       throw new ApiCallError(ErrorMessage.GenericRegistrationFail)
     }
   }
@@ -108,7 +108,7 @@ export class UserApiService implements UserApiServiceInterface {
       this.unlockOperation(UserApiOperations.UpdatingUser)
 
       return response
-    } catch (error) {
+    } catch {
       throw new ApiCallError(ErrorMessage.GenericFail)
     }
   }

packages/api/src/Domain/Client/WebSocket/WebSocketApiService.ts

@@ -27,7 +27,7 @@ export class WebSocketApiService implements WebSocketApiServiceInterface {
       this.operationsInProgress.set(WebSocketApiOperations.CreatingConnectionToken, false)
 
       return response
-    } catch (error) {
+    } catch {
       throw new ApiCallError(ErrorMessage.GenericFail)
     }
   }

packages/api/src/Domain/Request/AsymmetricMessage/GetOutboundAsymmetricMessagesRequestParams.ts

@@ -1,2 +1 @@
-// eslint-disable-next-line @typescript-eslint/ban-types
-export type GetOutboundAsymmetricMessagesRequestParams = {}
+export type GetOutboundAsymmetricMessagesRequestParams = Record<string, never>

packages/api/src/Domain/Request/AsymmetricMessage/GetUserAsymmetricMessagesRequestParams.ts

@@ -1,2 +1 @@
-// eslint-disable-next-line @typescript-eslint/ban-types
-export type GetUserAsymmetricMessagesRequestParams = {}
+export type GetUserAsymmetricMessagesRequestParams = Record<string, never>

packages/api/src/Domain/Request/SharedVaultInvites/GetOutboundUserInvitesRequestParams.ts

@@ -1,2 +1 @@
-// eslint-disable-next-line @typescript-eslint/ban-types
-export type GetOutboundUserInvitesRequestParams = {}
+export type GetOutboundUserInvitesRequestParams = Record<string, never>

packages/api/src/Domain/Request/SharedVaultInvites/GetUserInvitesRequestParams.ts

@@ -1,2 +1 @@
-// eslint-disable-next-line @typescript-eslint/ban-types
-export type GetUserInvitesRequestParams = {}
+export type GetUserInvitesRequestParams = Record<string, never>

packages/clipper/package.json

@@ -26,7 +26,7 @@
     "eslint": "*",
     "eslint-config-prettier": "^8.9.0",
     "ts-loader": "^9.4.2",
-    "typescript": "*",
+    "typescript": "5.8.3",
     "web-ext": "^7.5.0",
     "webextension-polyfill": "^0.10.0",
     "webpack": "*"

packages/desktop/.eslintrc.js

@@ -9,6 +9,7 @@ module.exports = {
   rules: {
     'no-console': ['warn', { allow: ['warn', 'error'] }],
     '@typescript-eslint/no-var-requires': 'off',
+    '@typescript-eslint/no-require-imports': 'off',
   },
   globals: {
     zip: true,

packages/desktop/app/index.ts

@@ -27,7 +27,7 @@ if (userDataPathIndex > 0) {
     /** Make sure the path is actually a writeable folder */
     try {
       fs.closeSync(fs.openSync(path.join(userDataPath, 'sn-test-file'), 'w'))
-    } catch (e) {
+    } catch {
       console.error('Failed to write to provided user data path. Aborting')
       app.exit(1)
     }

packages/desktop/app/javascripts/Main/File/FilesManager.ts

@@ -43,7 +43,7 @@ export class FilesManager implements FilesManagerInterface {
     try {
       const data = await fs.promises.readFile(filepath, 'utf8')
       return JSON.parse(data)
-    } catch (error) {
+    } catch {
       return undefined
     }
   }
@@ -286,7 +286,7 @@ export class FilesManager implements FilesManagerInterface {
   async moveFile(source: PathLike, destination: PathLike): Promise<void> {
     try {
       await fs.promises.rename(source, destination)
-    } catch (_error) {
+    } catch {
       /** Fall back to copying and then deleting. */
       await fs.promises.copyFile(source, destination, fs.constants.COPYFILE_FICLONE_FORCE)
       await fs.promises.unlink(source)

packages/desktop/app/javascripts/Main/Keychain/Keychain.ts

@@ -27,7 +27,7 @@ async function ensureKeychainAccess(store: Store): Promise<BrowserWindow | undef
     try {
       await getKeychainValue()
       store.set(StoreKeys.UseNativeKeychain, true)
-    } catch (_) {
+    } catch {
       /** Can't access keychain. */
       if (keychainAccessIsUserConfigurable) {
         return askForKeychainAccess(store)

packages/desktop/app/javascripts/Main/Packages/Networking.ts

@@ -47,7 +47,7 @@ export async function getJSON<T>(url: string): Promise<T | undefined> {
         try {
           const parsed = JSON.parse(data)
           resolve(parsed)
-        } catch (error) {
+        } catch {
           resolve(undefined)
         }
       })

packages/desktop/app/javascripts/Main/Types/Paths.ts

@@ -39,14 +39,14 @@ export const Paths = {
   get homeDir(): string | undefined {
     try {
       return app.getPath('home')
-    } catch (error) {
+    } catch {
       return undefined
     }
   },
   get documentsDir(): string | undefined {
     try {
       return app.getPath('documents')
-    } catch (error) {
+    } catch {
       return undefined
     }
   },

packages/desktop/app/javascripts/Main/Window.ts

@@ -260,7 +260,7 @@ function fileUrlsAreEqual(a: string, b: string): boolean {
       bPath = lowercaseDriveLetter(bPath)
     }
     return aPath === bPath
-  } catch (error) {
+  } catch {
     return false
   }
 }
@@ -275,7 +275,7 @@ async function getPreviousWindowPosition() {
   let position: WindowPosition
   try {
     position = JSON.parse(await fs.promises.readFile(path.join(Paths.userDataDir, 'window-position.json'), 'utf8'))
-  } catch (e) {
+  } catch {
     return {
       bounds: {
         width: WINDOW_DEFAULT_WIDTH,

packages/desktop/package.json

@@ -83,7 +83,7 @@
     "terser-webpack-plugin": "^5.3.6",
     "ts-loader": "^9.4.1",
     "ts-node": "^10.9.1",
-    "typescript": "*",
+    "typescript": "5.8.3",
     "webpack": "*",
     "webpack-merge": "*"
   },

packages/encryption/package.json

@@ -25,7 +25,7 @@
     "jest": "^29.3.1",
     "prettier": "*",
     "ts-jest": "^29.0.3",
-    "typescript": "*"
+    "typescript": "5.8.3"
   },
   "dependencies": {
     "@standardnotes/common": "^1.50.0",

packages/encryption/src/Domain/Operator/004/UseCase/Asymmetric/AsymmetricDecrypt.ts

@@ -41,7 +41,7 @@ export class AsymmetricDecrypt004 {
         signaturePublicKey: additionalData.signingData.publicKey,
         senderPublicKey: additionalData.senderPublicKey,
       }
-    } catch (error) {
+    } catch {
       return null
     }
   }

packages/encryption/src/Domain/Operator/004/UseCase/Asymmetric/AsymmetricDecryptOwnMessage.ts

@@ -44,7 +44,7 @@ export class AsymmetricDecryptOwnMessage004 implements SyncUseCaseInterface<Asym
         signaturePublicKey: additionalData.signingData.publicKey,
         senderPublicKey: additionalData.senderPublicKey,
       })
-    } catch (error) {
+    } catch {
       return Result.fail('Could not decrypt message')
     }
   }

packages/encryption/src/Domain/Operator/004/UseCase/Asymmetric/AsymmetricSignatureVerificationDetached.ts

@@ -27,7 +27,7 @@ export class AsymmetricSignatureVerificationDetached004 {
         signaturePublicKey: additionalData.signingData.publicKey,
         senderPublicKey: additionalData.senderPublicKey,
       }
-    } catch (error) {
+    } catch {
       return {
         signatureVerified: false,
       }

packages/features/package.json

@@ -41,6 +41,6 @@
     "eslint-plugin-prettier": "*",
     "jest": "^29.3.1",
     "ts-jest": "^29.0.3",
-    "typescript": "*"
+    "typescript": "5.8.3"
   }
 }

packages/filepicker/example/package.json

@@ -27,7 +27,7 @@
     "babel-loader": "^8.2.3",
     "html-webpack-plugin": "^5.5.0",
     "ts-loader": "^9.2.6",
-    "typescript": "*",
+    "typescript": "5.8.3",
     "typescript-eslint": "0.0.1-alpha.0",
     "webpack": "*",
     "webpack-cli": "*",

packages/filepicker/package.json

@@ -23,7 +23,7 @@
     "jest": "^29.3.1",
     "ts-jest": "^29.0.3",
     "ts-node": "^10.9.1",
-    "typescript": "*"
+    "typescript": "5.8.3"
   },
   "dependencies": {
     "@standardnotes/common": "^1.50.0",