[audit] remove dead nvim<0.12 branch from LspToggle#180
Closed
stanfish06 wants to merge 1 commit into
Closed
Conversation
The config already requires Neovim 0.12+ (vim.lsp.config, vim.lsp.enable, vim.pack are all 0.12 APIs), so the else branch calling the deprecated vim.lsp.stop_client() is unreachable dead code. Remove the version guard and call client:stop() unconditionally. https://claude.ai/code/session_01GHYEWxoG5uHqsZM28upN1w
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
lua/config/plugin_config.lua— theLspToggleuser command — contains a version guard that was added for backward compatibility with Neovim < 0.12:Where
lua/config/plugin_config.lua—LspTogglecommand body, lines 125–130.Why it matters
The config already requires Neovim 0.12+ exclusively:
vim.lsp.config(),vim.lsp.enable(), andvim.packare all 0.12 APIs used unconditionally throughout the config. Theelsebranch is therefore dead code — it can never execute — and it points atvim.lsp.stop_client(), which is deprecated in 0.12 and will be removed in a future version.Change
Remove the version guard; call
client:stop()unconditionally:Test plan
:LspToggle lualson a Lua buffer → luals stopsvim.lsp.stop_clientdeprecation warning in:checkhealthhttps://claude.ai/code/session_01GHYEWxoG5uHqsZM28upN1w
Generated by Claude Code