Add backend capability for changing datastore bump_enabled status - #169
Open
ben-c-2013 wants to merge 5 commits into
Open
ben-c-2013 wants to merge 5 commits into
ben-c-2013 wants to merge 5 commits into
Conversation
|
ben-c-2013
marked this pull request as ready for review
September 14, 2026 07:37
pawbu
reviewed
Sep 15, 2026
pawbu
left a comment
pawbu
left a comment
Contributor
There was a problem hiding this comment.
The OpenAPI documentation should be regenerated by running the application locally.
Could you add some integration tests in tests/integration/adapter/test_sqlite.py?
| return db_client.get_datastore(datastore_id).directory | ||
|
|
||
|
|
||
| @router.patch( |
Contributor
There was a problem hiding this comment.
PUT would be more in line with e.g. update_job. Also I think this could be just /{datastore_rdn}/bump-enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
PATCH /datastores/{datastore_rdn}/configuration endpoint.See task #761 for details.