feat(core): convert the gist api handler to TypeScript - #512
Open
marcalexiei wants to merge 1 commit into
Open
Conversation
|
@marcalexiei is attempting to deploy a commit to the martin-mfg's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another step of #140
api/gist.js➡️api/gist.tsparseFloat,parseBoolean); the card still defaults.Passing
undefinedfor an absent param keeps every default in one place.CommonOptions➡️CommonCardOptions, now extendingColorParamssince cards spreadtheir options into
getLightDarkColors.localemoved onto the four cards that read it: the gist card has no translated text.The gist handler no longer takes or validates it, so
/api/gist?locale=xxrenders the card instead of "Language not found". Docs has been updated.border_radiusis now validated at the boundary:?border_radius=abcreturns a permanentInvalid number input for parameter "border_radius"instead of a temporary error leakingCard's internalInvalid border radius: "NaN".