feat(frontend): Wizard - replace save-svg-as-png with a local converter - #540
Open
marcalexiei wants to merge 1 commit into
Open
feat(frontend): Wizard - replace save-svg-as-png with a local converter#540marcalexiei wants to merge 1 commit into
save-svg-as-png with a local converter#540marcalexiei wants to merge 1 commit into
Conversation
|
@marcalexiei is attempting to deploy a commit to the martin-mfg's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dropped the unmaintained (from June 2020) and untyped
save-svg-as-pngforwizard/components/Card/downloadSvgAsPng.ts:XMLSerializer➡️ data URL ➡️<img>➡️<canvas>➡️toBlob.The card SVGs are self-contained, so the library's style-inlining bought nothing.
Display.tsxnow reaches the card through a ref forwarded viaCardImagetoSvgInline, rather thangetElementById("svg-wrapper").Verified against the old library before removing it: both paths converted the stats and repo cards at
scale: 2, and the PNGs were diffed pixel by pixel in Chromium (via LLM).Dimensions match exactly; the few differing pixels are the library's, which copies rules matching nothing in the SVG out of the host page's stylesheets, and the injected font declaration shifts the glyphs.