feat: add C implementation for `stats/base/dists/lognormal/logcdf` by rautelaKamal · Pull Request #10882 · stdlib-js/stdlib

rautelaKamal · 2026-03-11T23:14:45Z

Description

What is the purpose of this pull request?

This pull request:

Adds a C implementation for evaluating the natural logarithm of the cumulative distribution function (CDF) of a lognormal distribution (@stdlib/stats/base/dists/lognormal/logcdf). Following the pattern of the JS version, the C logic log-transforms the input x and elegantly delegates to the existing C implementation of @stdlib/stats/base/dists/normal/logcdf.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

#3750

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

AI Assistance Disclosure

Yes
No

If yes, how was AI used?
I used an AI coding assistant to help generate the C native addon boilerplate, manifest files, and safely mirror the JS test logic/R fixtures into the native test files. I manually reviewed all outputs and verified compilation.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

stdlib-bot · 2026-03-11T23:18:27Z

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/base/dists/lognormal/logcdf	$\\color{green}281/281$ $\\color{green}+0.00\\%$	$\\color{green}18/18$ $\\color{green}+0.00\\%$	$\\color{green}4/4$ $\\color{green}+0.00\\%$	$\\color{green}281/281$ $\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

kgryte · 2026-04-12T11:29:23Z

@rautelaKamal You need to revert many of the changes made to this file.

kgryte · 2026-04-12T11:29:51Z

+		} else {
+			delta = abs( y - expected[ i ] );
+			tol = 1500.0 * EPS * abs( expected[ i ] );
+			t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. mu: '+mu[i]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' );


We should go ahead and migrate to using isAlmostSameValue for ULP-based testing.

I've migrated the tests to use isAlmostSameValue for ULP-based testing in the latest push. This PR should be ready for re-review.

Use the Unicode `µ`/`σ` symbols and the uppercase `ln(F(x;µ,σ))` notation in the C example, matching the JS example in the same README and the canonical `normal/logcdf` sibling. --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: passed - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: passed - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

Planeshifter

Let's get it in...

stdlib-bot · 2026-07-05T06:31:02Z

PR Commit Message

feat: add C implementation for `stats/base/dists/lognormal/logcdf`

PR-URL: https://github.com/stdlib-js/stdlib/pull/10882
Ref: https://github.com/stdlib-js/stdlib/issues/3750

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

stdlib-bot added Statistics Issue or pull request related to statistical functionality. Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. labels Mar 11, 2026

rautelaKamal marked this pull request as draft March 12, 2026 00:41

stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 12, 2026

rautelaKamal force-pushed the feat/stats/base/dists/lognormal/logcdf-c-port branch 3 times, most recently from 960fd26 to 36f518d Compare March 12, 2026 15:35

rautelaKamal marked this pull request as ready for review March 12, 2026 15:47

stdlib-bot added the Needs Review A pull request which needs code review. label Mar 12, 2026

This was referenced Mar 30, 2026

[RFC]: Develop native C implementations for probability distribution functions stdlib-js/google-summer-of-code#222

Closed

[RFC]: Develop native C implementations for probability distribution functions stdlib-js/google-summer-of-code#223

Closed

rautelaKamal force-pushed the feat/stats/base/dists/lognormal/logcdf-c-port branch from 36f518d to 6ecc2de Compare April 1, 2026 11:21

github-actions Bot mentioned this pull request Apr 1, 2026

[aw] No-Op Runs #11033

Closed

rautelaKamal force-pushed the feat/stats/base/dists/lognormal/logcdf-c-port branch from 6ecc2de to e454f06 Compare April 4, 2026 07:48

rautelaKamal force-pushed the feat/stats/base/dists/lognormal/logcdf-c-port branch from e454f06 to 14489bd Compare April 12, 2026 07:01

kgryte reviewed Apr 12, 2026

View reviewed changes

kgryte changed the title ~~feat: add C implementation for @stdlib/stats/base/dists/lognormal/logcdf~~ feat: add C implementation for stats/base/dists/lognormal/logcdf Apr 12, 2026

kgryte added difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Needs Changes Pull request which needs changes before being merged. review: 3 and removed Needs Review A pull request which needs code review. labels Apr 12, 2026

rautelaKamal force-pushed the feat/stats/base/dists/lognormal/logcdf-c-port branch from 14489bd to e705513 Compare April 13, 2026 07:06

rautelaKamal changed the title ~~feat: add C implementation for stats/base/dists/lognormal/logcdf~~ feat: add C implementation for stats/base/dists/lognormal/logcdf Apr 13, 2026

rautelaKamal force-pushed the feat/stats/base/dists/lognormal/logcdf-c-port branch from e705513 to 635e533 Compare April 13, 2026 08:53

rautelaKamal requested a review from a team April 20, 2026 13:14

stdlib-bot added the Needs Review A pull request which needs code review. label Apr 20, 2026

rautelaKamal requested a review from kgryte April 20, 2026 13:28

Planeshifter mentioned this pull request May 11, 2026

docs: add negative-scale @example to stats/base/dists/lognormal/cdf #12093

Merged

7 tasks

Planeshifter mentioned this pull request Jun 17, 2026

refactor: rename internal variables #12925

Merged

7 tasks

Planeshifter mentioned this pull request Jun 26, 2026

chore: align stats/base/dists/lognormal log* package descriptions with namespace majority #13153

Closed

7 tasks

Planeshifter mentioned this pull request Jul 5, 2026

Clean-up and land statistical distribution PRs stdlib-js/metr-issue-tracker#966

Closed

rautelaKamal and others added 2 commits July 5, 2026 00:42

feat: add C implementation for stats/base/dists/lognormal/logcdf

5698a99

Planeshifter force-pushed the feat/stats/base/dists/lognormal/logcdf-c-port branch from 36f7eaf to c1be4c9 Compare July 5, 2026 05:43

Planeshifter approved these changes Jul 5, 2026

View reviewed changes

Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jul 5, 2026

Planeshifter changed the title ~~feat: add C implementation for stats/base/dists/lognormal/logcdf~~ feat: add C implementation for stats/base/dists/lognormal/logcdf Jul 5, 2026

stdlib-bot removed the Needs Review A pull request which needs code review. label Jul 5, 2026

stdlib-bot removed the Needs Changes Pull request which needs changes before being merged. label Jul 5, 2026

Planeshifter merged commit 48157fa into stdlib-js:develop Jul 5, 2026
36 checks passed

stdlib-bot removed the Ready To Merge A pull request which is ready to be merged. label Jul 5, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: add C implementation for `stats/base/dists/lognormal/logcdf`#10882

feat: add C implementation for `stats/base/dists/lognormal/logcdf`#10882
Planeshifter merged 2 commits into
stdlib-js:developfrom
rautelaKamal:feat/stats/base/dists/lognormal/logcdf-c-port

rautelaKamal commented Mar 11, 2026

Uh oh!

stdlib-bot commented Mar 11, 2026 •

edited

Loading

Uh oh!

kgryte Apr 12, 2026

Uh oh!

kgryte Apr 12, 2026

Uh oh!

rautelaKamal Apr 14, 2026

Uh oh!

Planeshifter left a comment

Uh oh!

stdlib-bot commented Jul 5, 2026 •

edited by Planeshifter

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

rautelaKamal commented Mar 11, 2026

Description

What is the purpose of this pull request?

Related Issues

Questions

Other

AI Assistance Disclosure

Checklist

Uh oh!

stdlib-bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

kgryte Apr 12, 2026

Choose a reason for hiding this comment

Uh oh!

kgryte Apr 12, 2026

Choose a reason for hiding this comment

Uh oh!

rautelaKamal Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter left a comment

Choose a reason for hiding this comment

Uh oh!

stdlib-bot commented Jul 5, 2026 • edited by Planeshifter Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Commit Message

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

stdlib-bot commented Mar 11, 2026 •

edited

Loading

stdlib-bot commented Jul 5, 2026 •

edited by Planeshifter

Loading