Skip to content

chore: fix JavaScript lint errors#11211

Merged
kgryte merged 3 commits into
stdlib-js:developfrom
JE4NVRG:fix/lint-errors-11209
Jul 6, 2026
Merged

chore: fix JavaScript lint errors#11211
kgryte merged 3 commits into
stdlib-js:developfrom
JE4NVRG:fix/lint-errors-11209

Conversation

@JE4NVRG

@JE4NVRG JE4NVRG commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes issue #11209 by resolving 4 JavaScript lint errors detected in the automated lint workflow.

Changes

File Error Fix
repl/lib/regexp_require.js Missing empty line after require in JSDoc Added empty line
utils/async/until/lib/main.js new Array() not allowed Replaced with [] + .push()
strided/ops/sub/scripts/index.js Unused eslint-disable node/shebang Removed directive
constants/float64/pinf/lib/index.js Unused eslint-disable stdlib/require-globals Removed directive

Testing

All lint errors resolved. Run npm run lint to verify.

Related Issue

Fixes #11209


Let me know if you need any changes! 🚀

Contributor Acknowledgment

- regexp_require.js: add empty line between require statement and code
  in JSDoc examples (stdlib/jsdoc-example-require-spacing)
- async/until/main.js: replace new Array() with array literal and push
  (stdlib/no-new-array)
- strided/ops/sub/scripts/index.js: remove unused eslint-disable
  directive for node/shebang
- constants/float64/pinf/lib/index.js: remove unused eslint-disable
  directive for stdlib/require-globals

Resolves stdlib-js#11209
@stdlib-bot

Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot

Copy link
Copy Markdown
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. Potential Duplicate There might be another pull request resolving the same issue. labels Mar 30, 2026
@github-actions github-actions Bot mentioned this pull request Mar 31, 2026
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte

kgryte commented Apr 10, 2026

Copy link
Copy Markdown
Member

@JE4NVRG This PR cannot move forward until you address the comment in #11211 (comment) and update your OP.

@kgryte kgryte added status: Blocked Issue or pull request which is currently blocked. and removed Needs Review A pull request which needs code review. labels Apr 10, 2026
@stdlib-bot

stdlib-bot commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

No coverage information available.

@kgryte kgryte requested a review from a team July 6, 2026 05:58
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jul 6, 2026
@kgryte

kgryte commented Jul 6, 2026

Copy link
Copy Markdown
Member

@JE4NVRG Mind updating your OP as requested above? If we don't hear back in a week, I'll go ahead and mark this as stale and auto-close. Cheers!

@JE4NVRG

JE4NVRG commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the reminder. I updated the PR description with the contributing guidelines acknowledgment.

@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 5 and removed Needs Review A pull request which needs code review. status: Blocked Issue or pull request which is currently blocked. labels Jul 6, 2026
@kgryte

kgryte commented Jul 6, 2026

Copy link
Copy Markdown
Member

As the CI failure is not due to changes introduced in this PR, I'll go ahead and merge.

@kgryte kgryte changed the title chore: fix JavaScript lint errors (issue #11209) chore: fix JavaScript lint errors Jul 6, 2026
@kgryte kgryte merged commit 1396582 into stdlib-js:develop Jul 6, 2026
68 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Potential Duplicate There might be another pull request resolving the same issue. review: 5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants