Skip to content

chore: fix JavaScript lint errors#12088

Merged
kgryte merged 1 commit into
stdlib-js:developfrom
nightt5879:nightt5879/fix-js-lint-12086
May 11, 2026
Merged

chore: fix JavaScript lint errors#12088
kgryte merged 1 commit into
stdlib-js:developfrom
nightt5879:nightt5879/fix-js-lint-12086

Conversation

@nightt5879

@nightt5879 nightt5879 commented May 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • move the done callback out of setTopics so the callback is no longer an unnecessary nested function
  • keep done inside factory so it can continue to close over the user callback

Validation

  • node --check lib/node_modules/@stdlib/_tools/github/set-topics/lib/factory.js
  • node_modules\.bin\eslint --ignore-path .eslintignore --config etc/eslint/.eslintrc.js lib/node_modules/@stdlib/_tools/github/set-topics/lib/factory.js
  • git diff --check

Related Issues

Checklist

@stdlib-bot stdlib-bot added the Tools Issue or pull request related to project tooling. label May 11, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot

Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. labels May 11, 2026
@nightt5879 nightt5879 marked this pull request as ready for review May 11, 2026 02:35
@nightt5879 nightt5879 requested a review from a team May 11, 2026 02:35
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label May 11, 2026
@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 5 and removed Needs Review A pull request which needs code review. labels May 11, 2026
@kgryte kgryte changed the title chore: fix JavaScript lint errors (issue #12086) chore: fix JavaScript lint errors May 11, 2026
@kgryte kgryte merged commit b5f4143 into stdlib-js:develop May 11, 2026
121 of 122 checks passed
@nightt5879 nightt5879 deleted the nightt5879/fix-js-lint-12086 branch May 18, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. review: 5 Tools Issue or pull request related to project tooling.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants