Skip to content

feat: add float16 dtype support to array/zero-to-like#13055

Merged
kgryte merged 7 commits into
stdlib-js:developfrom
gururaj1512:float16-support/array/zero-to-like
Jul 5, 2026
Merged

feat: add float16 dtype support to array/zero-to-like#13055
kgryte merged 7 commits into
stdlib-js:developfrom
gururaj1512:float16-support/array/zero-to-like

Conversation

@gururaj1512

@gururaj1512 gururaj1512 commented Jun 22, 2026

Copy link
Copy Markdown
Member

Progresses #13193

Description

What is the purpose of this pull request?

This pull request:

  • feat: add float16 dtype support to array/zero-to-like

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

@gururaj1512 gururaj1512 requested a review from a team June 22, 2026 11:19
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jun 22, 2026
@gururaj1512 gururaj1512 marked this pull request as draft June 22, 2026 11:29
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jun 22, 2026
@kgryte kgryte added the bot: Merge Pull request needing the latest project code be merged in. label Jun 23, 2026
@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: Merge Pull request needing the latest project code be merged in. labels Jun 23, 2026
@stdlib-bot

stdlib-bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
array/zero-to-like $\\color{red}119/121$
$\\color{green}+0.00\\%$
$\\color{red}9/10$
$\\color{green}+0.00\\%$
$\\color{green}1/1$
$\\color{green}+0.00\\%$
$\\color{red}119/121$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@gururaj1512

Copy link
Copy Markdown
Member Author

@kgryte, what is causing the errors in the TypeScript declaration test files?

@kgryte kgryte added Feature Issue or pull request for adding a new feature. and removed bot: In Progress Pull request is currently awaiting automation. labels Jul 3, 2026
@kgryte kgryte marked this pull request as ready for review July 5, 2026 21:48
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jul 5, 2026

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The CI failure is expected given limitations in the current Float16Array type defn workaround.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jul 5, 2026
@kgryte kgryte merged commit e003221 into stdlib-js:develop Jul 5, 2026
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Issue or pull request for adding a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants