style: remove extra space and address lint failures#13263
Merged
Conversation
Propagates fix from b71a63d ("style: remove stray spaces") to sibling `docs/types` files carrying the same defect that the prior sweep missed.
Propagates fix from 1cecba9 ("chore: fix JavaScript lint errors") to `utils/pop/benchmark/benchmark.js`, which had the identical `new Array( len )` + indexed assignment pattern flagged by the `stdlib/no-new-array` ESLint rule in the sibling `utils/shift` benchmark.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
developbetween 2026-07-03 17:39 UTC and 2026-07-04 06:03 UTC to sibling packages carrying the same defects.style:— stray space before commaSweeps remaining stray space-before-comma occurrences that the prior propagation (
b71a63d) missed. The prior sweep's regex only matched identifiers surrounded by whitespace and skipped adjacent literals, object literals, and closing brackets. All hits are inside JSDoc@exampleblocks indocs/types/index.d.tsfiles or$ExpectErrorargument lists indocs/types/test.ts. Purely mechanical whitespace cleanup — no semantic change.Source commit:
b71a63dTarget packages:
array/base/broadcasted-quinary4d—docs/types/test.tsstring/base—docs/types/index.d.tsstring/base/replace-after—docs/types/index.d.ts,docs/types/test.tsstring/base/replace-after-last—docs/types/test.tsstring/base/replace-before—docs/types/test.tsstring/base/replace-before-last—docs/types/test.tsstring/replace-before—docs/types/test.tschore:—stdlib/no-new-arrayinutils/popbenchmarkApplies the same
new Array( len )→[]+arr.push( i )rewrite that1cecba9landed forutils/shift/benchmark/benchmark.jsto satisfy thestdlib/no-new-arrayESLint rule.utils/popis the sibling benchmark with a byte-identical setup block; the lint failure is the same.Source commit:
1cecba9Target packages:
utils/pop—benchmark/benchmark.jsRelated Issues
No.
Questions
No.
Other
Validation. Search scope was
docs/types/*.{ts,d.ts}for the stray-space pattern (repo-wide) andbenchmark/**/*.jsfor thenew Array( len )+ indexed-fill pattern (repo-wide). Two independent verifiers read every candidate site in full to confirm the defect against surrounding context; both flagged the same 43 stray-space lines across 8 files and both blocks inutils/pop/benchmark/benchmark.jsas unambiguous defects with no autogenerated /eslint-disablemarkers on any target file. Sites were deliberately excluded when they would require cross-package changes or interpretation of intent; none reached that bar in this run. Thepkg+'::native'→format( '%s::native', pkg )pattern from202e91cfound no valid remaining sites (repo-wide grep forpkg+'::returned zero hits — every benchmark already usesformat). TheLog logistic→Log-logistictypo from1fa83d8and the "Planck (discrete exponential)" clarification from8975f00also found no remaining sites — both are fully saturated.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was generated by Claude Code as part of a scheduled fix-propagation routine that mirrors recent
developfixes to sibling packages carrying the same defect. Each target site was independently verified by two adversarial reviewers before the patch was applied.@stdlib-js/reviewers
Generated by Claude Code