chore: clean-up#13283
Merged
Merged
Conversation
…x-equal` Align the TypeScript test file with the sibling `blas/ext/base/gfill-nan/docs/types/test.ts` added in the same batch and satisfy the `prefer-const` ESLint rule.
…ample Drop the redundant `var` in the module-level `@example` so the second `y` is a reassignment rather than a redeclaration, matching the sibling `logistic/cdf` example convention.
…e` example Drop the redundant `var` in the module-level `@example` so the second `y` is a reassignment rather than a redeclaration, matching the sibling `logistic/quantile` example convention.
Fix native.js `@returns` type to `PositiveNumber` (matches main.js and sibling anglit/variance/lib/native.js) and drop a stray blank line before the related-packages section in the README (every other README in this batch uses a single blank line here).
Rewrite native.js JSDoc to describe `mu`/`sigma` as `location parameter`/`scale parameter` to match main.js (wording had been copy-pasted from `normal/cdf` template). Add interior spaces to the `( lx < mu )` ternary in src/main.c to match the file's own conditional-spacing convention.
…escription The tape title for large `d1`/`d2` values opened `(tested against the Boost C++ library` but omitted the closing paren, unlike the two adjacent tape titles.
develop 2026-07-04..05develop on 2026-07-04..05
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
Jul 5, 2026
develop on 2026-07-04..05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fixes for commits merged to
developbetween 2026-07-04 16:17 CDT and 2026-07-05 16:39 GST (SHAsd2cee190..2c4aec3f, 22 first-parent commits).Grouped by package:
blas/ext/base/gfirst-index-equalvarwithconstthroughoutgfirst-index-equal/docs/types/test.ts— violatesprefer-constand inconsistent withgfill-nan'stest.tsadded in the same batch.stats/base/dists/log-logistic/cdfvar yredeclaration in the@exampleblock oflog-logistic/cdf/lib/index.js(e3c68d4); reassign instead, matchinglogistic/cdf. Would've trippedstdlib/no-redeclare.stats/base/dists/log-logistic/quantilevar yredeclaration in the@exampleblock oflog-logistic/quantile/lib/index.js(85820dd); reassign instead, matchinglogistic/quantile/lib/index.js.stats/base/dists/anglit/stdevstats/base/dists/anglit/stdev— correct@returns {number}to{PositiveNumber}inlib/native.jsto matchmain.jsandanglit/variance/lib/native.js, and drop the stray extra blank line before<section class="related">inREADME.md.stats/base/dists/lognormal/logcdfnative.js, fix JSDoc for lognormallogcdfto callmu/sigmathe location/scale parameters instead of copy-pasted mean/stdev wording; insrc/main.c:59, add missing interior spaces to the( lx < mu )ternary to match the rest of the file (48157fa).stats/base/dists/f/pdftest/test.native.js(82d0e4a) forstats/base/dists/f/pdf, matching the neighboring titles at lines 262 and 285.Related Issues
No.
Questions
No.
Other
Validation. The 24h commit window was audited for (a) stdlib style-guide compliance (JS/TS + C/Makefile/README) and (b) objective runtime bugs / logic errors in the introduced code, running four independent reviewers in parallel. Every finding above was re-verified against the actual working-tree source before applying a fix.
Deliberately excluded from this PR:
betaprime/modestill referencesequation_betaprime_expectation.svgafter the copy-paste rename in6e257ba3; fixing this cleanly requires regenerating the SVG asset (out of window) and updating the CDN URL — dropped rather than expanded scope.data.json, manifest entries).Test tolerances, duplicated sibling-package boilerplate, and the intentional
var optsshadowing innamespace/test.cli.jswere audited and confirmed deliberate — not flagged.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was produced by an automated review routine (Claude Code) that audits the last 24 hours of commits to
developfor typos, bugs, and style-guide violations, then applies fixes for validated high-signal issues. Each finding was surfaced by an independent reviewer agent, cross-checked against sibling-package conventions, and re-verified against the working-tree source before an edit was made. A human maintainer will review and promote from draft.@stdlib-js/reviewers
Generated by Claude Code