Skip to content

chore: clean-up#13283

Merged
kgryte merged 6 commits into
developfrom
philipp/fix-commit-review-2026-07-05
Jul 5, 2026
Merged

chore: clean-up#13283
kgryte merged 6 commits into
developfrom
philipp/fix-commit-review-2026-07-05

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

Follow-up fixes for commits merged to develop between 2026-07-04 16:17 CDT and 2026-07-05 16:39 GST (SHAs d2cee190..2c4aec3f, 22 first-parent commits).

Grouped by package:

blas/ext/base/gfirst-index-equal

  • 2c4aec3: replace var with const throughout gfirst-index-equal/docs/types/test.ts — violates prefer-const and inconsistent with gfill-nan's test.ts added in the same batch.

stats/base/dists/log-logistic/cdf

  • Fix duplicate var y redeclaration in the @example block of log-logistic/cdf/lib/index.js (e3c68d4); reassign instead, matching logistic/cdf. Would've tripped stdlib/no-redeclare.

stats/base/dists/log-logistic/quantile

  • Fix duplicate var y redeclaration in the @example block of log-logistic/quantile/lib/index.js (85820dd); reassign instead, matching logistic/quantile/lib/index.js.

stats/base/dists/anglit/stdev

  • f2d8482: fix doc/formatting nits in stats/base/dists/anglit/stdev — correct @returns {number} to {PositiveNumber} in lib/native.js to match main.js and anglit/variance/lib/native.js, and drop the stray extra blank line before <section class="related"> in README.md.

stats/base/dists/lognormal/logcdf

  • In native.js, fix JSDoc for lognormal logcdf to call mu/sigma the location/scale parameters instead of copy-pasted mean/stdev wording; in src/main.c:59, add missing interior spaces to the ( lx < mu ) ternary to match the rest of the file (48157fa).

stats/base/dists/f/pdf

  • Fix unclosed parenthesis in a tape title in test/test.native.js (82d0e4a) for stats/base/dists/f/pdf, matching the neighboring titles at lines 262 and 285.

Related Issues

No.

Questions

No.

Other

Validation. The 24h commit window was audited for (a) stdlib style-guide compliance (JS/TS + C/Makefile/README) and (b) objective runtime bugs / logic errors in the introduced code, running four independent reviewers in parallel. Every finding above was re-verified against the actual working-tree source before applying a fix.

Deliberately excluded from this PR:

  • Anything requiring interpretation or judgment (e.g. "consider naming this differently").
  • Style preferences not encoded in a style-guide rule or an existing sibling convention.
  • betaprime/mode still references equation_betaprime_expectation.svg after the copy-paste rename in 6e257ba3; fixing this cleanly requires regenerating the SVG asset (out of window) and updating the CDN URL — dropped rather than expanded scope.
  • Auto-generated content (namespace TOC, error-database CSV/JSON, R fixture data.json, manifest entries).

Test tolerances, duplicated sibling-package boilerplate, and the intentional var opts shadowing in namespace/test.cli.js were audited and confirmed deliberate — not flagged.

Checklist

AI Assistance

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was produced by an automated review routine (Claude Code) that audits the last 24 hours of commits to develop for typos, bugs, and style-guide violations, then applies fixes for validated high-signal issues. Each finding was surfaced by an independent reviewer agent, cross-checked against sibling-package conventions, and re-verified against the working-tree source before an edit was made. A human maintainer will review and promote from draft.


@stdlib-js/reviewers


Generated by Claude Code

claude added 6 commits July 5, 2026 12:28
…x-equal`

Align the TypeScript test file with the sibling `blas/ext/base/gfill-nan/docs/types/test.ts` added in the same batch and satisfy the `prefer-const` ESLint rule.
…ample

Drop the redundant `var` in the module-level `@example` so the second `y` is a reassignment rather than a redeclaration, matching the sibling `logistic/cdf` example convention.
…e` example

Drop the redundant `var` in the module-level `@example` so the second `y` is a reassignment rather than a redeclaration, matching the sibling `logistic/quantile` example convention.
Fix native.js `@returns` type to `PositiveNumber` (matches main.js and sibling anglit/variance/lib/native.js) and drop a stray blank line before the related-packages section in the README (every other README in this batch uses a single blank line here).
Rewrite native.js JSDoc to describe `mu`/`sigma` as `location parameter`/`scale parameter` to match main.js (wording had been copy-pasted from `normal/cdf` template). Add interior spaces to the `( lx < mu )` ternary in src/main.c to match the file's own conditional-spacing convention.
…escription

The tape title for large `d1`/`d2` values opened `(tested against the Boost C++ library` but omitted the closing paren, unlike the two adjacent tape titles.
@Planeshifter Planeshifter changed the title Follow-up fixes for commits merged to develop 2026-07-04..05 chore: apply follow-up fixes for commits merged to develop on 2026-07-04..05 Jul 5, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/gfirst-index-equal $\\color{green}272/272$
$\\color{green}+100.00\\%$
$\\color{green}20/20$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}272/272$
$\\color{green}+100.00\\%$
stats/base/dists/anglit/stdev $\\color{green}180/180$
$\\color{green}+100.00\\%$
$\\color{green}9/9$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}180/180$
$\\color{green}+100.00\\%$
stats/base/dists/f/pdf $\\color{red}599/647$
$\\color{green}+92.58\\%$
$\\color{red}62/66$
$\\color{green}+93.94\\%$
$\\color{green}6/6$
$\\color{green}+100.00\\%$
$\\color{red}599/647$
$\\color{green}+92.58\\%$
stats/base/dists/log-logistic/cdf $\\color{green}312/312$
$\\color{green}+100.00\\%$
$\\color{green}29/29$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}312/312$
$\\color{green}+100.00\\%$
stats/base/dists/log-logistic/quantile $\\color{green}318/318$
$\\color{green}+100.00\\%$
$\\color{green}33/33$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}318/318$
$\\color{green}+100.00\\%$
stats/base/dists/lognormal/logcdf $\\color{green}281/281$
$\\color{green}+100.00\\%$
$\\color{green}18/18$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}281/281$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte marked this pull request as ready for review July 5, 2026 19:58
@kgryte kgryte requested a review from a team July 5, 2026 19:58
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jul 5, 2026
@kgryte kgryte changed the title chore: apply follow-up fixes for commits merged to develop on 2026-07-04..05 chore: clean-up Jul 5, 2026
@kgryte kgryte merged commit 67f7557 into develop Jul 5, 2026
40 of 41 checks passed
@kgryte kgryte deleted the philipp/fix-commit-review-2026-07-05 branch July 5, 2026 19:59
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jul 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants