Skip to content

style: wrap ternary conditions in parentheses#13352

Merged
kgryte merged 1 commit into
developfrom
philipp/fix-ternary-parens-nan-incr
Jul 7, 2026
Merged

style: wrap ternary conditions in parentheses#13352
kgryte merged 1 commit into
developfrom
philipp/fix-ternary-parens-nan-incr

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request:

  • wraps the isnan ternary conditions in the @stdlib/stats/incr/nanmmin and @stdlib/stats/incr/nanmrss example files in parentheses to satisfy the stdlib/ternary-condition-parentheses lint rule.

These two examples were introduced by the recently merged stats/incr/nanmmin and stats/incr/nanmrss packages and currently trip the lint rule (38:25 error parentheses required around ternary conditions).

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request?

Purely a lint fix; no behavior change. Both example scripts run and produce identical output.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)

Disclosure

This lint fix was authored by Claude Code and reviewed by me.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Jul 7, 2026
Wrap the `isnan` ternary conditions in the nanmmin and nanmrss example
files to satisfy the stdlib/ternary-condition-parentheses lint rule.

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Planeshifter Planeshifter changed the title fix: wrap ternary conditions in parentheses in stats/incr examples style: wrap ternary conditions in parentheses in stats/incr examples Jul 7, 2026
@Planeshifter Planeshifter marked this pull request as ready for review July 7, 2026 05:38
@Planeshifter Planeshifter requested a review from a team July 7, 2026 05:38
@Planeshifter Planeshifter force-pushed the philipp/fix-ternary-parens-nan-incr branch from b20297d to d73f206 Compare July 7, 2026 05:38
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jul 7, 2026
@Planeshifter Planeshifter requested a review from kgryte July 7, 2026 05:38
@stdlib-bot

stdlib-bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/incr/nanmmin $\\color{green}145/145$
$\\color{green}+100.00\\%$
$\\color{green}8/8$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}145/145$
$\\color{green}+100.00\\%$
stats/incr/nanmrss $\\color{green}155/155$
$\\color{green}+100.00\\%$
$\\color{green}8/8$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}155/155$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jul 7, 2026
@kgryte kgryte changed the title style: wrap ternary conditions in parentheses in stats/incr examples style: wrap ternary conditions in parentheses Jul 7, 2026
@kgryte kgryte merged commit 563772f into develop Jul 7, 2026
33 checks passed
@kgryte kgryte deleted the philipp/fix-ternary-parens-nan-incr branch July 7, 2026 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants