Skip to content

docs: follow-up fixes for commits merged to develop on 2026-07-06/07#13360

Open
Planeshifter wants to merge 3 commits into
developfrom
philipp/fix-commit-review-2026-07-07
Open

docs: follow-up fixes for commits merged to develop on 2026-07-06/07#13360
Planeshifter wants to merge 3 commits into
developfrom
philipp/fix-commit-review-2026-07-07

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

Follow-up fixes for commits merged to develop between 2026-07-06 15:53 -0700 and 2026-07-07 00:50 -0700 (SHA range 1396582a1c^..c07a2afa, 40 commits, primarily new-package additions).

This pull request:

  • stats/incr/nancv (ade461ed): @throws message said "must provide a number"; wrapped incrcv accumulator and nanvariance both say "must provide a number primitive", so fixed to match. See lib/node_modules/@stdlib/stats/incr/nancv/lib/main.js:33.
  • blas/ext/base/gfirst-index-less-than (0932d0b2): Drop the lint disable maximum-heading-length and eslint-disable max-len comments copy-pasted from gfirst-index-greater-than; the heading is 79 chars and the offset example fits, so neither suppression is needed, matching gfirst-index-equal/gfirst-index-not-equal. See lib/node_modules/@stdlib/blas/ext/base/gfirst-index-less-than/README.md.
  • fft/base/fftpack/sinti (a2ccf2f5): Fix inconsistent spacing in floor(5*N/2) within the workspace-slice example — one call had spaces, the other didn't, across 4 copies of the same line. See lib/main.js:160, lib/index.js:46, README.md:66, docs/types/index.d.ts:57.

Related Issues

No.

Questions

No.

Other

Validation

  • Style-guide compliance audit (docs/style-guides/javascript/README.md) across every package added or modified in the window, comparing each new package against an established sibling of similar shape (e.g. nancv vs. cv/nanvariance; gfirst-index-less-than vs. gfirst-index-equal/gfirst-index-not-equal; sinti vs. sibling fftpack primitives).
  • Diff-only bug scan across all + lines (wrong operator, off-by-one on visible loop bounds, mistyped identifiers, doc-example outputs vs. code) — no runtime bugs surfaced.
  • Introduced-code correctness scan focused on the wax family C kernels, generic accessor-aware primitives (gfirst-index-less-than/greater-than/gfill-not-equal/gindex-of-not-equal), stats/incr/nan* accumulators, sinti sine-table computation, and the rffti1 twiddle-factor fix (im = 2im = 1) — no defects.

Deliberately excluded

  • Subjective concerns and preferences not required by docs/style-guides/*.
  • Anything requiring interpretation or code outside the window's diff to validate.
  • Findings deliberately author-driven (e.g. the rffti1 im change, the ternary-parenthesization pass, the pareto-type1 isnan guards, the dlast-index-of/slast-index-of idx collapse).

Checklist

AI Assistance

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was authored by an automated stdlib review routine: the last 24h of commits merged to develop were audited by four parallel review agents (two style-guide reviewers, two bug scanners), findings were cross-verified against sibling packages, and only high-signal issues that could be independently re-verified against the diff were applied. Each fix was hand-checked before commit.



Generated by Claude Code

claude added 3 commits July 7, 2026 12:30
Aligns the JSDoc `@throws` tag with the wrapped `incrcv` accumulator
and the parallel `nanvariance` package, which both document the guard
as "must provide a number primitive".
…less-than`

The `.ndarray()` subheading (79 characters) is under the 80-character
limit and the offset-indexing example line is also within the eslint
`max-len` threshold, so the `lint disable maximum-heading-length` and
`eslint-disable max-len` comments are unnecessary. Matches the README
structure of the sibling `gfirst-index-equal` and `gfirst-index-not-equal`
packages.
…/sinti` examples

The `floor( 5*N/2 )` call in the trailing `workspace.slice` example
appeared without interior spacing, sitting next to a correctly-spaced
`floor( 5*N/2 )` call on the same line. Applied to `lib/main.js`,
`lib/index.js`, `README.md`, and `docs/types/index.d.ts` so all four
copies of the example match the stdlib whitespace convention.
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/gfirst-index-less-than $\\color{green}272/272$
$\\color{green}+100.00\\%$
$\\color{green}21/21$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}272/272$
$\\color{green}+100.00\\%$
fft/base/fftpack/sinti $\\color{red}255/257$
$\\color{green}+99.22\\%$
$\\color{red}4/5$
$\\color{green}+80.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{red}255/257$
$\\color{green}+99.22\\%$
stats/incr/nancv $\\color{green}141/141$
$\\color{green}+100.00\\%$
$\\color{green}11/11$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}141/141$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter marked this pull request as ready for review July 7, 2026 16:41
@Planeshifter Planeshifter requested review from a team and kgryte July 7, 2026 16:41
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants