docs: follow-up fixes for commits merged to develop on 2026-07-06/07#13360
Open
Planeshifter wants to merge 3 commits into
Open
docs: follow-up fixes for commits merged to develop on 2026-07-06/07#13360Planeshifter wants to merge 3 commits into
Planeshifter wants to merge 3 commits into
Conversation
Aligns the JSDoc `@throws` tag with the wrapped `incrcv` accumulator and the parallel `nanvariance` package, which both document the guard as "must provide a number primitive".
…less-than` The `.ndarray()` subheading (79 characters) is under the 80-character limit and the offset-indexing example line is also within the eslint `max-len` threshold, so the `lint disable maximum-heading-length` and `eslint-disable max-len` comments are unnecessary. Matches the README structure of the sibling `gfirst-index-equal` and `gfirst-index-not-equal` packages.
…/sinti` examples The `floor( 5*N/2 )` call in the trailing `workspace.slice` example appeared without interior spacing, sitting next to a correctly-spaced `floor( 5*N/2 )` call on the same line. Applied to `lib/main.js`, `lib/index.js`, `README.md`, and `docs/types/index.d.ts` so all four copies of the example match the stdlib whitespace convention.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fixes for commits merged to
developbetween 2026-07-06 15:53 -0700 and 2026-07-07 00:50 -0700 (SHA range1396582a1c^..c07a2afa, 40 commits, primarily new-package additions).This pull request:
stats/incr/nancv(ade461ed):@throwsmessage said "must provide a number"; wrappedincrcvaccumulator andnanvarianceboth say "must provide a number primitive", so fixed to match. Seelib/node_modules/@stdlib/stats/incr/nancv/lib/main.js:33.blas/ext/base/gfirst-index-less-than(0932d0b2): Drop thelint disable maximum-heading-lengthandeslint-disable max-lencomments copy-pasted fromgfirst-index-greater-than; the heading is 79 chars and the offset example fits, so neither suppression is needed, matchinggfirst-index-equal/gfirst-index-not-equal. Seelib/node_modules/@stdlib/blas/ext/base/gfirst-index-less-than/README.md.fft/base/fftpack/sinti(a2ccf2f5): Fix inconsistent spacing infloor(5*N/2)within the workspace-slice example — one call had spaces, the other didn't, across 4 copies of the same line. Seelib/main.js:160,lib/index.js:46,README.md:66,docs/types/index.d.ts:57.Related Issues
No.
Questions
No.
Other
Validation
docs/style-guides/javascript/README.md) across every package added or modified in the window, comparing each new package against an established sibling of similar shape (e.g.nancvvs.cv/nanvariance;gfirst-index-less-thanvs.gfirst-index-equal/gfirst-index-not-equal;sintivs. siblingfftpackprimitives).+lines (wrong operator, off-by-one on visible loop bounds, mistyped identifiers, doc-example outputs vs. code) — no runtime bugs surfaced.waxfamily C kernels, generic accessor-aware primitives (gfirst-index-less-than/greater-than/gfill-not-equal/gindex-of-not-equal),stats/incr/nan*accumulators,sintisine-table computation, and therffti1twiddle-factor fix (im = 2→im = 1) — no defects.Deliberately excluded
docs/style-guides/*.rffti1imchange, the ternary-parenthesization pass, thepareto-type1isnanguards, thedlast-index-of/slast-index-ofidxcollapse).Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by an automated stdlib review routine: the last 24h of commits merged to
developwere audited by four parallel review agents (two style-guide reviewers, two bug scanners), findings were cross-verified against sibling packages, and only high-signal issues that could be independently re-verified against the diff were applied. Each fix was hand-checked before commit.Generated by Claude Code