test: migrate stats/base/dists/chi/logpdf to ULP-based assertions - #14839
Draft
kgryte wants to merge 1 commit into
Draft
test: migrate stats/base/dists/chi/logpdf to ULP-based assertions#14839kgryte wants to merge 1 commit into
stats/base/dists/chi/logpdf to ULP-based assertions#14839kgryte wants to merge 1 commit into
Conversation
Replace relative tolerance comparisons with `isAlmostSameValue` ULP difference assertions in the `stats/base/dists/chi/logpdf` tests. Ref: #11352 Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UYyqUPEukY4soPWzpgy8RV --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
stdlib-bot
added
Statistics
Contributor
|
Hello! 👋 We've noticed that you've been opening a number of PRs addressing good first issues. Thank you for your interest and enthusiasm! Now that you've made a few contributions, we suggest no longer working on good first issues. Instead, we encourage you to prioritize cleaning up any PRs which have yet to be merged and then proceed to work on more involved tasks. Not only does this ensure that other new contributors can work on things and get ramped up on all things stdlib, it also ensures that you can spend your time on more challenging problems. 🚀 For ideas for future PRs, feel free to search the codebase for TODOs and FIXMEs and be sure to check out other open issues on the issue tracker. Cheers! |
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/base/dists/chi/logpdffrom relative tolerance comparisons to ULP difference assertions using@stdlib/assert/is-almost-same-value.The following files are updated:
test/test.logpdf.js(was2.0 * EPS * abs( expected[ i ] )) → 2 ULPtest/test.factory.js(was2.0 * EPS * abs( expected[ i ] )) → 2 ULPtest/test.native.js(was40.0 * EPS * abs( expected[ i ] )) → 2 ULPULP bounds
Each bound is the measured minimum. Over the full
decimal_decimal.jsonfixture set (5000 cases), the maximum observed ULP difference against the expected values is2for each of the main,factory, and native implementations, attained atx = 0.048002235420554484,k = 2.39848473901088. At1ULP, all three implementations fail on that same case; at0ULP, six cases fail. The bounds were tightened downward from an initial value of64and the suite was run twice at the final value to confirm determinism.The native add-on was compiled locally (
node-gyp rebuild) so thattest/test.native.jsexecutes rather than skips; the previous40.0 * EPSnative tolerance turned out to be considerably looser than required, as the C implementation agrees with the JavaScript implementation on this fixture set.Only test files are touched; no implementation or fixture changes are included.
Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
While measuring, I noticed that the native results for this function are sensitive to floating-point contraction: compiling
src/main.cwith FMA contraction enabled (e.g.,-march=native -ffp-contract=fast) raises the maximum observed difference from2to48ULP. stdlib'sbinding.gypbuilds with-O3 -std=c99and no-marchoverride, so the2ULP bound holds for the add-on as actually built here (verified against the compiled.node), but reviewers may want to confirm on an architecture where FMA contraction is the compiler default (e.g., arm64).Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code, running unattended as a scheduled task. It studied previously merged ULP migrations to mirror the established idiom, applied the edits, and searched for the minimum passing ULP bound empirically.
@stdlib-js/reviewers
Generated by Claude Code