feat: add C implementation for blas/ext/base/ndarray/dcusum - #14846
Open
Nehant14 wants to merge 1 commit into
Open
feat: add C implementation for blas/ext/base/ndarray/dcusum#14846Nehant14 wants to merge 1 commit into
blas/ext/base/ndarray/dcusum#14846Nehant14 wants to merge 1 commit into
Conversation
stdlib-bot
added
BLAS
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: passed
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: passed
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: missing_dependencies
- task: lint_c_examples
status: missing_dependencies
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
Nehant14
force-pushed
the
feat/dcusum-ndarray-c
branch
from
August 31, 2026 11:57
de690ff to
bfa978e
Compare
MeKaustubh07
changed the title
blas/ext/base/ndarray/dcusum
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves part of #14819.
Description
This pull request:
blas/ext/base/ndarray/dcusum, computing the cumulative sum of a one-dimensional double-precision floating-point ndarraysrc/main.c,src/addon.c,include/stdlib/blas/ext/base/ndarray/dcusum.h,binding.gyp,include.gypi,manifest.json,src/Makefile,examples/c/Makefile, andexamples/c/example.clib/index.jsto prefer the native addon, falling back to the existing pure JavaScript implementation when the addon is unavailable, and addslib/native.jsto load ittest/test.native.js), mirroring the existing JavaScript test suitetest.native.jscorrectly skips rather than fails when the addon is unavailable, and that the C example's output matches a manually computed cumulative sumRelated Issues
This pull request has the following related issues:
blas/ext/base/ndarraypackages #14819Questions
No.
Other
lint_c_srcandlint_c_examplesshowmissing_dependenciesin the static analysis report becausecppcheckis not installed in my local dev environment; CI should run this check properly.Checklist
AI Assistance
If yes:
Disclosure
I used Claude to help debug local build/tooling issues (a missing
src/Makefileandexamples/c/Makefilerequired for the native-addon build pipeline, and a stale build cache that silently prevented the compiled addon from being copied tosrc/addon.node), and to independently verify the C example's cumulative-sum output against manual calculation. The implementation itself was authored by me; AI tools were used for debugging and verification only.