Skip to content

build(workflows): stream PR list when checking for duplicate PRs #14850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Planeshifter wants to merge 1 commit into
base: develop
Choose a base branch
from
+4 −6
Draft

build(workflows): stream PR list when checking for duplicate PRs #14850

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions .github/workflows/scripts/check_duplicate_prs/run
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,14 +255,12 @@ main() {
echo "Processing PRs for issue references..."
debug_log "Starting to process $total_prs PRs for issue references"

# Process PRs one by one...
# Process PRs one by one, streaming the list through a single `jq` invocation in order to avoid re-parsing the entire list once per PR...
processed_count=0

for ((i=0; i<total_prs; i++)); do
pr=$(echo "$open_prs" | jq -c ".[$i]")

while IFS= read -r pr; do
if [ -z "$pr" ] || [ "$pr" = "null" ]; then
debug_log "Warning: Empty PR data at index $i"
debug_log "Warning: Empty PR data"
continue
fi

Expand Down Expand Up @@ -300,7 +298,7 @@ main() {
issue_prs_values[index]="${issue_prs_values[index]} $pr_number"
fi
done
done
done < <(echo "$open_prs" | jq -c '.[]')

debug_log "Finished processing all PRs for issue references"
debug_log "Found ${#issue_prs_keys[@]} unique issues referenced in PRs"
Expand Down