Skip to content

feat(lib): added stats/incr/nanmmin package#5849

Merged
Planeshifter merged 9 commits into
stdlib-js:developfrom
jalajk3004:nanmin
Jul 7, 2026
Merged

feat(lib): added stats/incr/nanmmin package#5849
Planeshifter merged 9 commits into
stdlib-js:developfrom
jalajk3004:nanmin

Conversation

@jalajk3004

Copy link
Copy Markdown
Contributor

Resolves #5594

Description

What is the purpose of this pull request?

This pull request:

  • adds a package nanmmin, which works like mmin in which it calculates mmin incrementally ignoring NaN values

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 7, 2025
@ShabiShett07

Copy link
Copy Markdown
Contributor

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label May 2, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label May 2, 2025
}
}

// EXPORTS //

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// EXPORTS //
// EXPORTS //
module.exports = incrnanmmin

@stdlib-bot

stdlib-bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/incr/nanmmin $\\color{green}145/145$
$\\color{green}+0.00\\%$
$\\color{green}8/8$
$\\color{green}+0.00\\%$
$\\color{green}2/2$
$\\color{green}+0.00\\%$
$\\color{green}145/145$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter force-pushed the nanmin branch 2 times, most recently from 2f95b77 to 7aa5e3c Compare July 7, 2026 05:01
- Delegate to @stdlib/stats/incr/mmin to avoid reimplementing the moving-min logic (mirrors nanmstdev/nanmin), which fixes the PINF sentinel leaking as a result on a leading NaN (now returns null)
- Revert unintended modification of the existing incr/mmin package
- Correct an incorrect expected fixture value in the incremental test
- Fix incrmmin -> incrnanmmin references in README and index.d.ts examples
- Reindent with tabs; remove unused test imports and trailing whitespace
- Normalize package.json formatting; add nan/ignore keywords

@Planeshifter Planeshifter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after edits

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jul 7, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

PR Commit Message

feat(lib): added `stats/incr/nanmmin` package

PR-URL: https://github.com/stdlib-js/stdlib/pull/5849
Closes: https://github.com/stdlib-js/stdlib/issues/5594

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jul 7, 2026
@Planeshifter Planeshifter merged commit aa89fb3 into stdlib-js:develop Jul 7, 2026
31 checks passed
@stdlib-bot stdlib-bot removed the Ready To Merge A pull request which is ready to be merged. label Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add stats/incr/nanmmin

4 participants