feat: add stats/incr/nancv#5949
Merged
Merged
Conversation
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Member
|
@jalajk3004 Your header files for |
Member
|
All lint errors need to be resolved before this PR can be reviewed. |
Contributor
Author
|
All lint errors are resolved, you can review this PR |
- Forward the optional `mean` argument to incrcv (previously dropped, so the documented incrnancv([mean]) known-mean API was non-functional and silently ignored the argument) - Correct the known-mean test, which asserted the unknown-mean result (0.5) and thereby masked the dropped-argument bug; expected value is now sqrt(2/3)/2 - Add a test asserting a TypeError is thrown for a non-number mean - Guard the example against a null accumulated value (previously crashed via cv.toFixed on a leading NaN) - Remove incorrect NaN-propagation note from index.d.ts; fix README/description NaN wording and example values - Bump copyright year to 2026
Contributor
PR Commit MessagePlease review the above commit message and make any necessary adjustments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5555
Description
This pull request:
Related Issues
This pull request:
stats/incr/nancv#5555Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers