fix: dump progress output and stricter rate limit overrides - #40
Merged
Conversation
The lists are fetched up front so that the size of the walk is known before it starts, but those requests are paced like any other. On a tenant with many teams, or under a reduced allowance, nothing was printed until every list had arrived — minutes of silence that reads as a hang. A dot per team lands as each list comes back, so the first output is immediate and progress is visible throughout.
The overrides were parsed with Number, which reads '0x10' as 16, '1e3' as 1000 and '2.5' as two and a half. None of those is how a request count gets written on purpose, and accepting them changes how hard the CLI hits the platform without saying so — the same quiet failure the warning on a bad value exists to prevent. Plain decimal digits are required, with surrounding whitespace still tolerated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two follow-ups left open from the review of #35.
Progress during the list-gathering phase
experiment dumpfetches every team's experiment list up front so it can report the size of the walk before starting it. Those requests are paced like any other, so on a tenant with many teams — or with a reducedSTEADYBIT_RATE_LIMIT_*allowance — nothing was printed until all of them had arrived. While testing #35 that was over ten minutes of silence, which is indistinguishable from a hang.A dot per team now lands as each list comes back:
Stricter parsing of the rate limit overrides
The overrides went through
Number, which reads0x10as 16,1e3as 1000 and2.5as two and a half. None of those is how a request count gets written on purpose, and accepting them changes how hard the CLI hits the platform without saying so — the same quiet failure the warning on a bad value exists to prevent.Plain decimal digits are now required; surrounding whitespace is still tolerated.
Verification
npm run cigreen at both commits (82 and 88 tests), so the history bisects cleanly. Both changes were also exercised against a livedeveloptenant — the output in both sections above is real, not illustrative.