ci: migrate to npm 12 - #167
Merged
Merged
Conversation
|
Claude finished @achoimet's task in 59s —— View job Claude finished reviewing this PR
No prior unresolved Claude review threads exist on this PR, so nothing to reconcile. ReviewThis is a small, well-scoped CI change (npm 12 default global-install upgrade) and I didn't find any correctness bugs, security issues, or race conditions.
Nothing else stood out — the change looks safe to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm 12 disables install scripts by default, including for global installs — see the npm v12.0.0 release notes.
--allow-scripts=snyk— its postinstall bootstraps the CLI binary (without it, snyk still works but lazily downloads the binary on first run; at release time the explicit approval is clearer). Verified both behaviors on npm 12.0.2.--ignore-scripts.This reusable workflow is consumed by all extension repos, so this single change migrates their CI too.
Part of the org-wide npm 12 CI migration.